Closed Bug 913826 Opened 6 years ago Closed 6 years ago

New social bookmark button: rename entities to reflect string changes

Categories

(Firefox Graveyard :: SocialAPI, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
Firefox 26

People

(Reporter: flod, Assigned: flod)

References

Details

Attachments

(1 file)

Putting together all changes coming from bug 891219

-<!ENTITY social.markpage.accesskey "m">
+<!ENTITY social.markpage.accesskey "P">

-<!ENTITY social.marklink.accesskey "M">
+<!ENTITY social.marklink.accesskey "L">

-social.markpage.label=Send Page to %S
+social.markpage.label=Save Page to %S

-social.marklink.label=Send Link to %S
+social.marklink.label=Save Link to %S

-social.unmarkpage.label=Remove Page from %S
-social.unmarklink.label=Remove Link from %S


I'm sorry but all these strings require a new ID.
https://developer.mozilla.org/en-US/docs/Making_String_Changes
Not really a developer, so please check if I did everything right. Unfortunately this change is quite urgent, since it must land before the migration to Aurora (i.e. this week).
Attachment #802352 - Flags: review?(mixedpuppy)
Comment on attachment 802352 [details] [diff] [review]
Use new ID for changed strings

applied and tested the patch, everything looks good.
Attachment #802352 - Flags: review?(mixedpuppy) → review+
Not sure of :flod can push, and given the relative urgency of this, I'm hoping the sheriffs might pick it up.
Assignee: nobody → francesco.lodolo
Status: NEW → ASSIGNED
Whiteboard: checkin-needed
(In reply to Mark Hammond (:markh) from comment #3)
> Not sure of :flod can push, and given the relative urgency of this, I'm
> hoping the sheriffs might pick it up.

Thanks Mark, no pushing rights here so you did the right thing :-)
https://hg.mozilla.org/integration/fx-team/rev/7fa0fd335e9f

FYI, you can just set the checkin-needed bug keyword in the future rather than editing the whiteboard :)
Whiteboard: checkin-needed → [fixed-in-fx-team]
https://hg.mozilla.org/mozilla-central/rev/7fa0fd335e9f
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Flags: in-testsuite+
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → Firefox 26
Product: Firefox → Firefox Graveyard
You need to log in before you can comment on or make changes to this bug.