Closed Bug 913851 Opened 7 years ago Closed 7 years ago

Minimize the #includes in js/xpconnect

Categories

(Core :: XPConnect, defect)

x86
macOS
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: ehsan, Assigned: ehsan)

References

(Blocks 2 open bugs)

Details

Attachments

(1 file)

Attached patch Patch (v1)Splinter Review
https://tbpl.mozilla.org/?tree=Try&rev=59a2845e027f
Attachment #801149 - Flags: review?(bobbyholley+bmo)
Blocks: 913869
I think the Windows link error was because of a class/struct mismatch.  Hopefully this patch fixes it:

https://tbpl.mozilla.org/?tree=Try&rev=2fc3f8379b22
Comment on attachment 801149 [details] [diff] [review]
Patch (v1)

Review of attachment 801149 [details] [diff] [review]:
-----------------------------------------------------------------

\o/

Was this done with IWYU or some similarly-automated tool? I sure hope so. :-)
Attachment #801149 - Flags: review?(bobbyholley+bmo) → review+
(In reply to Bobby Holley (:bholley) from comment #6)
> Was this done with IWYU or some similarly-automated tool? I sure hope so. :-)

Yeah, I'm using IWYU for all of this stuff.  I'm not as awesome as I'd like to make it look like.  ;-)
https://hg.mozilla.org/mozilla-central/rev/77cd72a836e6
Status: NEW → RESOLVED
Closed: 7 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.