913868 - nsCoord.h is a hub header

Status: NEW

(Core :: Graphics, defect)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Attachment: Trim nsCoord

A hub header is one that is included by many other headers, and itself includes many other headers. See tracking bug 912735.

Comment 1

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 801166 [details] [diff] [review]
Trim nsCoord

Review of attachment 801166 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/src/nsCoord.h
@@ +23,1 @@
>  

I'm not thrilled with this approach, at the same time I can appreciate its value. Perhaps you can convince me more.

Comment 2

[Nick Cameron [:nrc]]

It seems there are a lot of files which pull in algorithm and/or cmath just for min/max (or floor/ceil in some cases). Could we create an mfbt header with these simple functions and use that rather than defining them again and again in various header files?

Comment 3

[Benoit Jacob [:bjacob] (mostly away)]

Good questions. I started a thread on dev-platform: "Including <algorithm> just to get std::min and std::max"

Comment 4

[Jeff Muizelaar [:jrmuizel]]

Comment on attachment 801166 [details] [diff] [review]
Trim nsCoord

Based on the discussion on dev-platform it sounds like this is not a good approach.