913869 - Trim BindingUtils.h some more

Status: NEW

(Core :: DOM: Core & HTML, defect, P5)

Description

[Benoit Jacob [:bjacob] (mostly away)]

Bug 909003 just made it a lot better.

We should still:
 - stop including <algorithm> , see bug 913852
 - stop including <nsThreadUtils.h>, see bug 913847 which makes us include a new MainThreadUtils.h instead,
 - stop including that new MainThreadUtils.h, see bug 909971
 - anything else?

Comment 1

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

Is BindingUtils.h really included by a lot of *headers*? I'd usually prefer avoiding including BindingUtils.h itself (outside of dom/bindings/).

Comment 2

[Andrew McCreight [:mccr8]]

According to my MXRing, the only real headers that include it are WebGLContextUtils.h and XPCQuickStubs.h.

Comment 3

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

The following generated headers include BindingUtils.h (directly); might be worth investigating if those are included too much.

AudioContextBinding.h
DOMMMIErrorBinding.h
DOMTransactionBinding.h
EventHandlerBinding.h
EventListenerBinding.h
FunctionBinding.h
FutureBinding.h
GeolocationBinding.h
MediaStreamEventBinding.h
MutationObserverBinding.h
NavigatorBinding.h
NodeFilterBinding.h
NotificationBinding.h
PhoneNumberServiceBinding.h
PromiseBinding.h
PushManagerBinding.h
RTCDataChannelEventBinding.h
RTCIceCandidateBinding.h
RTCPeerConnectionBinding.h
RTCPeerConnectionIceEventBinding.h
RTCSessionDescriptionBinding.h
SettingsManagerBinding.h
TestCodeGenBinding.h
TestJSImplGenBinding.h
TestJSImplInheritanceGenBinding.h
WebComponentsBinding.h
WindowBinding.h

Comment 4

[(no longer active)]

(In reply to Andrew McCreight [:mccr8] from comment #2)
> According to my MXRing, the only real headers that include it are
> WebGLContextUtils.h and XPCQuickStubs.h.

I'm removing the latter in bug 913851.

Comment 5

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

(In reply to :Ehsan Akhgari (needinfo? me!) from comment #4)
> (In reply to Andrew McCreight [:mccr8] from comment #2)
> > According to my MXRing, the only real headers that include it are
> > WebGLContextUtils.h and XPCQuickStubs.h.
> 
> I'm removing the latter in bug 913851.

And the former actually needs the include, and isn't really included anywhere.

Comment 6

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1472046

Move all DOM bugs that haven’t been updated in more than 3 years and has no one currently assigned to P5.

If you have questions, please contact :mdaly.