913926 - [fr] Update searchplugin icons on comm-central

Status: RESOLVED FIXED

(Mozilla Localizations :: fr / French, defect)

Description

[Théo Chevalier]

Attachment: mozilla-central patch

Yahoo! recently updated their logo, we need to reflect the change in searchplugins.

The icon has been edited from http://fr.yahoo.com/favicon.ico

Only the mobile icon is 32×32 pixels.

Comment 1

[Théo Chevalier]

Attachment: comm-central patch

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 801244 [details] [diff] [review]
comm-central patch

Review of attachment 801244 [details] [diff] [review]:
-----------------------------------------------------------------

I'm going to punt this to pike, since I'd merely be rubber stamping and he is flagged for the m-c based patches so this should be a quick review for him right after the other review.

Comment 3

[Axel Hecht [:Pike]]

Joanne, is this a change we're doing across the board?

Comment 4

[Joanne Nagel]

Hi, thanks for checking in.  I just received the following email and not had a chance to setup a bug yet.  Please note the target date for completion is Oct. 5th...please feel free to prioritize accordingly.  If you have questions for Yahoo, just let me know and I'll follow-up with the partner managers.  Thanks! Joanne

Valued Partner:

Over the past year, there's been a renewed sense of purpose and progress at Yahoo.  We've introduced beautiful new products that have changed the way people see the weather, read email, share photos, and follow their favorite sports teams. We've partnered with great artists including Macklemore and Ryan Lewis, John Legend, and Imagine Dragons to take Yahoo On The Road. And of course, we are excited to come together with Tumblr and by extension its incredible community of creators. We want everything we do to reflect this spirit of innovation. So while the company is rapidly evolving, our brand and logo should too.
 
Today we are thrilled to announce that our new logo launched globally.  The new logo maintains the characteristics that are unique to Yahoo —  the color purple, our iconic exclamation point, our personality and enthusiasm — but is now more sophisticated and refined.  The relationship between each hand-crafted character is intentional and emblematic of the collaborative culture that is driving us forward as a company.  The dimensional effect on each letter captures the depth and scale of Yahoo and our products. We believe this logo captures where we are as a company, and where we are heading.

We appreciate your ongoing partnership and hope you are as excited as we are about the momentum at Yahoo. Thank you for supporting us during this change.  

You can access the new logo here (ftp://dropbox.yahoo.com/ ; username: brand-partner; password: GBIRwmSR).  We look forward to seeing our new logo on your site and respectfully request that this take place by October 5th.

If you have any questions, please feel free to contact me or your partner manager.

Comment 5

[Justin Wood (:Callek)]

(In reply to Joanne Nagel from comment #4)
> Hi, thanks for checking in.  I just received the following email and not had
> a chance to setup a bug yet.  Please note the target date for completion is
> Oct. 5th...please feel free to prioritize accordingly.  If you have
> questions for Yahoo, just let me know and I'll follow-up with the partner
> managers.  Thanks! Joanne

I'll note, for prioritizations sake, that the version of our software which will be current and for GA on Oct 5, is slated to officially release September 17, and have its "Go to build" on September 9 (today).

So if we just need to change it on our end by Oct5 that's one thing, if they want it live for all current users by Oct 5, this has a strong deadline on our end.

Comment 6

[Joanne Nagel]

Ok, so the message for yahoo is that we'll make the change by Oct. 5, but it won't be visible to the majority of our users until FF25 releases on Oct. 29th?  Is that accurate?

Comment 7

[Axel Hecht [:Pike]]

I think that the majority of localizations will have this fix in 26, actually. That is unless we spend additional resources into uplifting the fixes for the locales affectd.

Comment 8

[Théo Chevalier]

Note that for Thunderbird it won't be 26, but next year's release

Comment 9

[Axel Hecht [:Pike]]

I'm not sure if the icons are as good as we can get them, given the reference material that Joanne linked to.

Comment 10

[Francesco Lodolo [:flod]]

It could be me but on the FTP repository I see only complete YAHOO! logos, no favicons (and favicon.ico on yahoo.com contains both 16px and 32px).

Comment 11

[Théo Chevalier]

Microsoft updated Bing logo today, we could take both changes at the same time.

Comment 12

[Axel Hecht [:Pike]]

Joanne, the artwork on yahoo's dropbox doesn't contain a favicon, and I'm not happy with the one we have here in the bug yet.

Can you try to get some high-resolution images for us from yahoo and bing? I'd favor 16 and 32, and maybe even something larger or actually large to scale down to 64 or 128 or whatever mobile might need at some point.

Comment 13

[Joanne Nagel]

Ok, let me see what I can do...

Comment 14

[Joanne Nagel]

Attachment: yahoo_logo_jpg

I sent your request to Yahoo and this is the file they sent.  I'll also attach a MacOS version.

Let me know if you need something different and I'll follow-up.  Still waiting on Bing response.

Joanne

Comment 15

[Joanne Nagel]

Attachment: Yahoo__MACOSX.zip

Comment 16

[Francesco Lodolo [:flod]]

The __MACOSX is a fake folder (I haven't seen those in a while), hiding the attachment.

The package is still missing the favicon, there are only complete logos (entire YAHOO! text).

See for example the 32px favicon extracted from favicon.ico
https://bug755723.bugzilla.mozilla.org/attachment.cgi?id=800672

Comment 17

[Joanne Nagel]

Attachment: Yahoo! Final_Favicon.png

Here is the favicon - this is the only version they have.

Comment 18

[Joanne Nagel]

Hi,

What is the status of this?  I am using nightly and it's still the old favicon so it doesn't seem to be riding the trains.  Yahoo is asking when this will be completed.

Thanks,
Joanne

Comment 19

[Francesco Lodolo [:flod]]

This never landed, right now only the mobile searchplugin had an updated icon.

Comment 20

[Joanne Nagel]

We need to land this asap - we are obligated to update their branding.

Comment 21

[Théo Chevalier]

Francesco, what needs to be done? Should I update the patch with the Yahoo favicon that landed on mobile (resized to 16x16) and the Bing favicon attached on Bug 903084? Even if en-US is not using it yet (I think the old Bing favicon is still used on en-US)?

Comment 22

[Francesco Lodolo [:flod]]

(In reply to Joanne Nagel from comment #20)
> We need to land this asap - we are obligated to update their branding.

en-US does not have updated icons for Bing or Yahoo or Desktop. Therefore I didn't think this was this urgent.
http://hg.mozilla.org/mozilla-central/log/7433abfef863/browser/locales/en-US/searchplugins/bing.xml
http://hg.mozilla.org/mozilla-central/log/7433abfef863/browser/locales/en-US/searchplugins/yahoo.xml

Comment 23

[Joanne Nagel]

I supplied Yahoo's favicon on 9/20/2013 - if there is a problem with that creative asset, please advise.  Otherwise we need to get this uploaded to desktop for all locales.

Comment 24

[Jeff Beatty [:gueroJeff]]

(In reply to Joanne Nagel from comment #23)
> I supplied Yahoo's favicon on 9/20/2013 - if there is a problem with that
> creative asset, please advise.  Otherwise we need to get this uploaded to
> desktop for all locales.

With all due respect, the problem is understanding the expectations here. To say that this needs to be done "asap" when the favicons have not even been updated on en-US contradicts the "asap" priority. A lot of locales rely on the en-US searchplugin (i.e., the en-US file is used in the l10n build). Before we can start with locales, it has to land on en-US. Please push engineering to get this into en-US and then describe the priority level for this. At that point we can give you an estimate as to how long it will take to update this in all relevant locales. In the meantime, we'll compile a list of all of the affected locales. Please file a meta tracking bug for this issue so that we can keep from spamming the French bug.

Please understand that this will be done in tandem with Firefox metro p12n, being the case, we'll need to understand what the priority between the two is. With each locale having its own repo and its own maintainer, this change will require time.

Comment 25

[Joanne Nagel]

So help me understand what should have happened once this bug was created and I submitted the favicon?  I provided the timeline target from the partner and according to comment #7, the majority of locales would have it in FF26, but it appeared that it would go to GA in en-US for FF25.  

I need to be able to explain to our partner why we did not make that date - can someone explain where the breakdown occurred?  I have no visibility into what the process actually is, so this will be helpful the next time a partner makes a request.  In the meantime, since I work on the business development team, i have no idea how the metabug would have to be configured in order to solve this problem.  Can you please assist?

Comment 26

[Axel Hecht [:Pike]]

Joanne, you're talking in the bug about the French localization. I'll keep my comment short here, because I don't think it's helpful in this particular bug to have a lot of back and forth about general process.

Please discuss this in a bug for Fennec and the en-US version, and once that's resolved, we can follow up with localizations. If you don't know if there's a bug, feel free to file a bug and CC :kar, me and Jeff.

As for discussions about what partner issues make it into which release, Karen is probably the best person to talk to. She'll coordinate the discussion about how to localize those issues with Jeff and me.

Comment 27

[Francesco Lodolo [:flod]]

Changes to Yahoo mobile have already landed from Beta in this cycle (bug 931109), changes to Yahoo desktop landed in Aurora and Central as part of bug 939834.

http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/8b4116fa4d6d
http://hg.mozilla.org/l10n-central/fr/rev/8b4116fa4d6d

I'd say you only need the comm-central patch now. Can you reuse the same icon I'm using for desktop? I'll be glad to review it based on Callek's comment 2. Not sure why this bug talks about Bing though.

Comment 28

[Théo Chevalier]

(In reply to Francesco Lodolo [:flod] from comment #27)
> Changes to Yahoo mobile have already landed from Beta in this cycle (bug
> 931109), changes to Yahoo desktop landed in Aurora and Central as part of
> bug 939834.
> 
> http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/8b4116fa4d6d
> http://hg.mozilla.org/l10n-central/fr/rev/8b4116fa4d6d
> 
> I'd say you only need the comm-central patch now. Can you reuse the same
> icon I'm using for desktop? I'll be glad to review it based on Callek's
> comment 2. Not sure why this bug talks about Bing though.

Thanks Francesco for the Desktop update.
I basically copy/pasted your changes to comm-central searchplugins

(When I created the bug, I thought we had a locale-specific bing searchplugin, so nevermind :) )

Comment 29

[Théo Chevalier]

Attachment: patch for comm-central

Comment 30

[Francesco Lodolo [:flod]]

Comment on attachment 8336187 [details] [diff] [review]
patch for comm-central

Review of attachment 8336187 [details] [diff] [review]:
-----------------------------------------------------------------

Changes look good to me.

Since now repos are in good shape, I suggest you land this on mozilla-aurora, then merge down to l10n-central
1. hg pull -r default ../mozilla-aurora
2. hg merge
3. (check the changes, if everything is ok) hg commit -m "Merge Aurora to Central"
4. hg push

Comment 31

[Théo Chevalier]

Thanks, pushed

http://hg.mozilla.org/l10n-central/fr/rev/a7ab19a5d287
http://hg.mozilla.org/releases/l10n/mozilla-aurora/fr/rev/a7ab19a5d287