Closed Bug 913938 Opened 11 years ago Closed 11 years ago

[homescreen] Make the panning a little smoother at the start

Categories

(Firefox OS Graveyard :: Gaia::Homescreen, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: julienw, Assigned: julienw)

Details

Attachments

(1 file)

This is a small enhancement that lets us use the panning resolver for the first move.

I can feel a very small enhancement, but this is subjective. Anyway, the code is a little cleaner too.
Attached patch patch v1Splinter Review
github pull request is at https://github.com/mozilla-b2g/gaia/pull/12011

Use the defined "pan" function for the first move too.
---
 apps/homescreen/js/grid.js |   23 ++++++++++++-----------
 1 file changed, 12 insertions(+), 11 deletions(-)


No new unit test because we have existing unit tests that cover that area already (if I'm not wrong). Please tell me if you'd like more :)
Attachment #801275 - Flags: review?(crdlc)
Comment on attachment 801275 [details] [diff] [review]
patch v1

Review of attachment 801275 [details] [diff] [review]:
-----------------------------------------------------------------

Good job as usual, thanks a lot Julien
Attachment #801275 - Flags: review?(crdlc) → review+
master: 254cfdf38965d977136d7325e54b418295276e65

thanks Cristian :)
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: