Closed Bug 913948 Opened 7 years ago Closed 7 years ago

getCachedBySubdomainAndName's array length should be optional from JS

Categories

(Toolkit :: General, defect)

defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: neil, Assigned: neil)

References

Details

Attachments

(2 files)

As with all idl array return values; c.f. bug 525710.

There are some tests that attempt to verify its parameter validation but they also assume that the length is optional. These tests still pass with the length made optional, of course: https://tbpl.mozilla.org/?tree=Try&rev=2a717fee6fbc
Attached patch Proposed patchSplinter Review
Assignee: nobody → neil
Status: NEW → ASSIGNED
Attachment #801282 - Flags: review?(dtownsend+bugmail)
Attached patch Possible patchSplinter Review
In case you think it needs a UUID change.
Attachment #801283 - Flags: review?(dtownsend+bugmail)
(Doesn't block 909093, I didn't use getCachedBySubdomainAndName after all.)
No longer blocks: 909093
I think you added a dep for the wrong bug. This is unrelated to bug 699589.
No longer blocks: 699589
Attachment #801282 - Flags: review?(dtownsend+bugmail) → review-
Comment on attachment 801283 [details] [diff] [review]
Possible patch

Review of attachment 801283 [details] [diff] [review]:
-----------------------------------------------------------------

Apparently the iid change isn't necessary in these cases but is recommended so let's do that.
Attachment #801283 - Flags: review?(dtownsend+bugmail) → review+
My bad, I typoed the blocking bug number.
https://hg.mozilla.org/mozilla-central/rev/d453acd106f5
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.