Don't show 'Ignore Thread', 'Ignore Subthread', and 'Watch Thread' menu items on non-mail, special tabs like 'Troubleshooting information'

RESOLVED FIXED in Thunderbird 26.0

Status

defect
RESOLVED FIXED
6 years ago
5 years ago

People

(Reporter: aryx, Assigned: aryx)

Tracking

Trunk
Thunderbird 26.0
x86
Windows XP
Dependency tree / graph

Thunderbird Tracking Flags

(thunderbird24 fixed, thunderbird25 fixed)

Details

Attachments

(2 attachments)

Thunderbird 24.0b2, Daily 20130904030204

Don't show 'Ignore Thread', 'Ignore Subthread', and 'Watch Thread' menu items on non-mail, special tabs like 'Troubleshooting information'.
Posted patch patch, v1Splinter Review
[Approval Request Comment]
Regression caused by (bug #): bug 179033
User impact if declined: Context menu in non-mail tabs shows "Ignore Thread", "Ignore Subthread", "Watch Thread" (haven't tested what happens if you click on them)
Testing completed (on c-c, etc.): no
Risk to taking this patch (and alternatives if risky): [If the context menus match]: None.
Assignee: nobody → archaeopteryx
Status: NEW → ASSIGNED
Attachment #801298 - Flags: review?(mbanner)
Attachment #801298 - Flags: approval-comm-beta?
Attachment #801298 - Flags: approval-comm-aurora?
Attachment #801298 - Flags: review?(mbanner)
Attachment #801298 - Flags: review+
Attachment #801298 - Flags: approval-comm-beta?
Attachment #801298 - Flags: approval-comm-beta+
Attachment #801298 - Flags: approval-comm-aurora?
Attachment #801298 - Flags: approval-comm-aurora+
https://hg.mozilla.org/comm-central/rev/52ce01123f03
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → Thunderbird 26.0
I hadn't added the new separator to the list of separators, so it gets shown at the end of the menu. This patch hides it.

I will file a bug to remove this static separator list in later Thunderbird versions.
Attachment #804900 - Flags: review?(mbanner)
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(In reply to Archaeopteryx [:aryx] from comment #4)
> I will file a bug to remove this static separator list in later Thunderbird
> versions.
Filed as bug 916482.
Comment on attachment 804900 [details] [diff] [review]
also hide separator, patch, v1

Looks good, but if we want this on branches, please move the patch to a separate bug so we can use the tracking flags appropriately.
Attachment #804900 - Flags: review?(mbanner) → review+
Status: REOPENED → RESOLVED
Closed: 6 years ago5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.