913968 - Windows builds broken on comm-central

Status: RESOLVED FIXED

(Firefox Build System :: General, defect)

Description

[Joshua Cranmer [:jcranmer]]

Distinct from the other tier traversal change failures. I haven't looked in detail.

Comment 1

[Mike Hommey [:glandium]]

Bug 912832 apparently broke building without MOZ_FOLD_LIBS on windows. There are two things that should be done here (and this bug would need to be cloned):
- Fix the non-MOZ_FOLD_LIBS problem
- Use MOZ_FOLD_LIBS on c-c. There's no reason not to. See https://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#57

Comment 2

[Mike Hommey [:glandium]]

Attachment: Don't link nspr libraries until the libs tier on non-MOZ_FOLD_LIBS builds

Comment 3

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 801343 [details] [diff] [review]
Don't link nspr libraries until the libs tier on non-MOZ_FOLD_LIBS builds

Review of attachment 801343 [details] [diff] [review]:
-----------------------------------------------------------------

kinda ugly, but ok

Comment 4

[Mike Hommey [:glandium]]

https://hg.mozilla.org/mozilla-central/rev/740094c07328

Comment 5

[Frank Wein [:mcsmurf]]

I filed Bug 915571 for the new(?) Windows build problem, Thunderbird trunk fails to find mozcrt.lib when it tries to link/create nsldif32v60.dll