Closed Bug 913968 Opened 6 years ago Closed 6 years ago

Windows builds broken on comm-central

Categories

(Firefox Build System :: General, defect, blocker)

x86_64
Windows 7
defect
Not set
blocker

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: jcranmer, Assigned: glandium)

References

Details

Attachments

(1 file)

Distinct from the other tier traversal change failures. I haven't looked in detail.
Bug 912832 apparently broke building without MOZ_FOLD_LIBS on windows. There are two things that should be done here (and this bug would need to be cloned):
- Fix the non-MOZ_FOLD_LIBS problem
- Use MOZ_FOLD_LIBS on c-c. There's no reason not to. See https://mxr.mozilla.org/mozilla-central/source/browser/confvars.sh#57
Blocks: 912832
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Product: MailNews Core → Core
Comment on attachment 801343 [details] [diff] [review]
Don't link nspr libraries until the libs tier on non-MOZ_FOLD_LIBS builds

Review of attachment 801343 [details] [diff] [review]:
-----------------------------------------------------------------

kinda ugly, but ok
Attachment #801343 - Flags: review?(khuey) → review+
Attachment #801343 - Flags: review?(ted)
Attachment #801343 - Flags: review?(gps)
https://hg.mozilla.org/mozilla-central/rev/740094c07328
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
I filed Bug 915571 for the new(?) Windows build problem, Thunderbird trunk fails to find mozcrt.lib when it tries to link/create nsldif32v60.dll
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.