914026 - Crash resizing a detached-iframe (or closed) window

Status: VERIFIED FIXED

(Core :: DOM: Core & HTML, defect)

Description

[Jesse Ruderman]

Attachment: testcase (crashes Firefox when loaded)

Regression from bug 891763.

+ if (mDocShell->GetIsBrowserOrApp()) {

With this testcase, mDocShell is null, so it crashes.

Comment 1

[Kan-Ru Chen [:kanru] (UTC+9)]

Attachment: Check mDocShell before use

Comment 2

[Kyle Huey (Exited; not receiving bugmail, old account, do not use)]

Comment on attachment 810435 [details] [diff] [review]
Check mDocShell before use

Review of attachment 810435 [details] [diff] [review]:
-----------------------------------------------------------------

r=me

Comment 3

[Kan-Ru Chen [:kanru] (UTC+9)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/67fadc732e63

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/67fadc732e63

Comment 5

[Kyle Wooten]

Thanks!

Comment 6

[Ekanan Ketunuti]

Verified fixed on Nightly 27.0a1 buildid 20131010030202.

Comment 7

[Lukas Blakk [:lsblakk] use ?needinfo]

Can we get an uplift nomination here to the beta channel with a risk/reward assessment?

Comment 8

[Kan-Ru Chen [:kanru] (UTC+9)]

Comment on attachment 810435 [details] [diff] [review]
Check mDocShell before use

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 891763
User impact if declined: browser crashes if the website tries to resize a detached iframe or closed window. 
Testing completed (on m-c, etc.): already in firefox27
Risk to taking this patch (and alternatives if risky): little to none
String or IDL/UUID changes made by this patch: none

Comment 9

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-beta/rev/bfd0f8d7509f

Comment 10

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/releases/mozilla-b2g26_v1_2/rev/bfd0f8d7509f