Closed Bug 914028 Opened 11 years ago Closed 11 years ago

Display video (camera) device list in permission acquisition prompt

Categories

(Firefox OS Graveyard :: Gaia::System, defect)

Other
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:-)

RESOLVED FIXED
blocking-b2g -

People

(Reporter: gasolin, Assigned: gasolin)

References

Details

(Whiteboard: [FT:System-Platform])

Attachments

(4 files)

To support Display camera permission acquisition prompt,

Permission Manager need to show the available device list get from gecko, with single select option box near it.
Depends on: 913896
Assignee: nobody → gasolin
Depends on: 898949
Attached image UX mockup
add UX mockup for reference, will take l10n into concern
blocking-b2g: --- → 1.3?
Whiteboard: [FT:System-Platform]
WIP, wait gecko ready to test
Attached image WIP screenshot
Plus it because it blocked the gUM permission on video/camera.
blocking-b2g: 1.3? → 1.3+
Per discussion offline - gUM camera support is a targeted feature, not committed, which means we don't need to block on this. We should try to get this in for 1.3 still, however.
blocking-b2g: 1.3+ → -
Blocks: 923361
No longer depends on: 944584
I'd suggest add one edge case for usability: 

hide the option list if there's only 1 option, just set that option as default choice (ex: unagi or inari only have back camera)

Patryk, how do you think?
Flags: needinfo?(padamczyk)
Agreed. If there is only one camera (usually the rear), you shouldn't need to see the list, its redundant. The user just needs to see the question: "Would like like to share you camera?"
Flags: needinfo?(padamczyk)
Comment on attachment 8333744 [details] [review]
pull request redirect to github

Test with SC's test-version gecko and everything seems fine now.

1. Form the list if there's more than 1 options
2. single selection
3. wider selection area that user can tape anywhere to select the line of option
4. fix 'remember' issue by initialize variables in the very beginning
Attachment #8333744 - Flags: review?(alive)
Comment on attachment 8333744 [details] [review]
pull request redirect to github

r+ if function is split.
Attachment #8333744 - Flags: review?(alive) → review+
I'll send a separately patch for some base fix in 1.3, and land this list support on 1.4.
After some function split, it seems works well in SC's test-version gecko 

merged to gaia-master
https://github.com/mozilla-b2g/gaia/commit/3af264075dc9a69ec420f5cf5cd7cc216677f2e4
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Keywords: verifyme
QA Contact: jsmith
QA Contact: jsmith
Keywords: verifyme
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: