914032 - Slim down even more -inl.h files

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

This follows on from bug 910771.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: (part 1) - Invert the dependency between vm/Shape.h and vm/ObjectImpl.h.

vm/Shape.h currently depends on vm/ObjectImpl.h.  This patch inverts this
dependence.  I had to move a few things (most notable PropDesc.h) from the
latter to the former, but it's mostly straightforward.

Comment 2

[Nicholas Nethercote [inactive]]

Attachment: (part 2) - Move a bunch of stuff out of -inl.h files.

This is nice.  Two -inl.h files bite the dust, as do several |uninlined*()|
functions, and vm/ObjectImpl.h roughly halves in size.

Comment 3

[Nicholas Nethercote [inactive]]

Attachment: (part 3) - Move a bunch more stuff out of -inl.h files.

Lots of barrier movement here.  These functions are all so repetitive, I'm sure
they could be templatized.  But not right now.

Comment 4

[Terrence Cole [:terrence]]

Comment on attachment 801469 [details] [diff] [review]
(part 1) - Invert the dependency between vm/Shape.h and vm/ObjectImpl.h.

Review of attachment 801469 [details] [diff] [review]:
-----------------------------------------------------------------

Nice! r=me

Comment 5

[Terrence Cole [:terrence]]

Comment on attachment 801472 [details] [diff] [review]
(part 2) - Move a bunch of stuff out of -inl.h files.

Review of attachment 801472 [details] [diff] [review]:
-----------------------------------------------------------------

The dependency inversion between shape and object has always bugged me, precisely because it prevents us from using lastProperty in the header. Good to know that is actually as significant a cleanup as I imagined. r=me

::: js/src/gc/Barrier.cpp
@@ +50,5 @@
>  }
>  
>  #endif // DEBUG
>  
> +#ifdef DEBUG

You can probably merge these two adjacent DEBUG sections.

Comment 6

[Terrence Cole [:terrence]]

Comment on attachment 801473 [details] [diff] [review]
(part 3) - Move a bunch more stuff out of -inl.h files.

Review of attachment 801473 [details] [diff] [review]:
-----------------------------------------------------------------

Yes, the pre-barriers in particular are pretty much uniform. r=me

Comment 7

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/c8175c00be1e
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea1af870680c
https://hg.mozilla.org/integration/mozilla-inbound/rev/ea33604f6232

Comment 8

[:Ms2ger (he/him; ⌚ UTC+1/+2)]

https://hg.mozilla.org/mozilla-central/rev/c8175c00be1e
https://hg.mozilla.org/mozilla-central/rev/ea1af870680c
https://hg.mozilla.org/mozilla-central/rev/ea33604f6232