Closed Bug 914125 Opened 12 years ago Closed 11 years ago

Export page doesn't handle errors

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
x86
macOS
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
1.2 C3(Oct25)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: fcampo, Assigned: fcampo)

Details

(Whiteboard: [u=commsapps-user c=contacts p=0])

Attachments

(1 file)

Lin to PR - https://github.com/mozilla-b2g/gaia/pull/12831
46 bytes, text/x-github-pull-request
arcturus
: review+
Details | Review
When exporting contacts to either of the available options, and an error occurs, there's no handling of it on contacts app. We should at least show an overlay with the error message.
This is more a matter of polishing to me, so not asking for koi, but feel free to prove me wrong ;)
I believe it should be koi, we need to notify the user, otherwise what would happen?
Whiteboard: [u=commsapps-user c=contacts p=0]
Asking koi? per comment 2.
blocking-b2g: --- → koi?
Assignee: nobody → fernando.campo
blocking-b2g: koi? → koi+
Target Milestone: --- → 1.2 C3(Oct25)
Attachment #816678 - Flags: review?(francisco.jordano)
Comment on attachment 816678 [details] [review] Lin to PR - https://github.com/mozilla-b2g/gaia/pull/12831 r+ when solved the comments in github. In general, pretty good job, just a couple of comments, that shouldn't take that long.
Attachment #816678 - Flags: review?(francisco.jordano) → review+
Attachment mime type: text/plain → text/x-github-pull-request
PR updated with the comments merged on master 1248ea07e150211f1713625ba5140d59e269068c Cheers!
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Uplifted 1248ea07e150211f1713625ba5140d59e269068c to: v1.2: 7f78fc7d35860eb89e319bfe9c861b55345d6986
status-b2g-v1.2: --- → fixed
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: