Closed
Bug 914175
Opened 11 years ago
Closed 11 years ago
[B2G] [Bluetooth] Reply error when no profile is connected
Categories
(Firefox OS Graveyard :: Bluetooth, defect)
Tracking
(blocking-b2g:koi+, firefox26 fixed)
Tracking | Status | |
---|---|---|
firefox26 | --- | fixed |
People
(Reporter: gyeh, Assigned: gyeh)
References
Details
Attachments
(1 file, 2 obsolete files)
There's a bit API changes in Bug 906305. For BluetoothAdpater.connect(device), BluetoothProfileController would try to connect multiple profiles based on the class of device (CoD). The DOMRequest is returned once all processes has been done. However, if none of the profiles is successfully connected, we should reply the DOM request with an error.
Assignee | ||
Comment 1•11 years ago
|
||
Eric, please review this patch. Thanks.
Assignee: nobody → gyeh
Attachment #801616 -
Flags: review?(echou)
Assignee | ||
Updated•11 years ago
|
blocking-b2g: --- → koi?
Assignee | ||
Comment 2•11 years ago
|
||
In the final patch, I'd like to add comments in BluetoothAdapter.webidl to describe how to use our API.
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Comment 3•11 years ago
|
||
Comment on attachment 801616 [details] [diff] [review] Patch 1(v1): Reply error when no profile is connected Review of attachment 801616 [details] [diff] [review]: ----------------------------------------------------------------- r- because the logic of setting mSuccess doesn't cover the "one profile link established, but the other one failed" scenario. ::: dom/bluetooth/BluetoothProfileController.cpp @@ +30,5 @@ > MOZ_ASSERT(aCallback); > > mProfilesIndex = -1; > mProfiles.Clear(); > + mSuccess = true; nit: using field initialization should be fine. ::: dom/bluetooth/BluetoothProfileManagerBase.h @@ +14,5 @@ > */ > #define ERR_ALREADY_CONNECTED "AlreadyConnectedError" > #define ERR_ALREADY_DISCONNECTED "AlreadyDisconnectedError" > +#define ERR_CONNECTION_FAILED "ConnectionFailed" > +#define ERR_DISCONNECTION_FAILED "DisconnectionFailed" nit: please append 'Error' to both strings for consistency
Attachment #801616 -
Flags: review?(echou) → review-
Assignee | ||
Comment 4•11 years ago
|
||
Eric, the patch has been updated. Please take a look, thanks.
Attachment #801616 -
Attachment is obsolete: true
Attachment #802245 -
Flags: review?(echou)
Comment 5•11 years ago
|
||
Comment on attachment 802245 [details] [diff] [review] Patch 1(v2): Reply error when no profile is connected Review of attachment 802245 [details] [diff] [review]: ----------------------------------------------------------------- Looks good. Thanks :)
Attachment #802245 -
Flags: review?(echou) → review+
Assignee | ||
Comment 6•11 years ago
|
||
Thanks.
Assignee | ||
Comment 7•11 years ago
|
||
try: https://tbpl.mozilla.org/?tree=Try&rev=e19d30f00bd9
Attachment #802245 -
Attachment is obsolete: true
Assignee | ||
Comment 8•11 years ago
|
||
https://hg.mozilla.org/integration/b2g-inbound/rev/8ca9a823fc2c
Comment 9•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/8ca9a823fc2c
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → 1.2 FC (16sep)
Comment 10•11 years ago
|
||
This needs to be backed out. This caused bug 915812, which breaks a daily smoketest for bluetooth.
Flags: needinfo?(ryanvm)
Comment 11•11 years ago
|
||
This doesn't seem to be the reason why bug 915812 occurs. It could also be a Gaia problem since we've done some changes both in Gecko and Gaia recently. I'll do a quick investigation and see if this patch is a problem.
Updated•11 years ago
|
status-firefox26:
--- → fixed
You need to log in
before you can comment on or make changes to this bug.
Description
•