If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

[Integration Test] Open Tab Tray

RESOLVED WONTFIX

Status

Firefox OS
Gaia::Browser
RESOLVED WONTFIX
4 years ago
4 years ago

People

(Reporter: nhirata, Assigned: nhirata)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 2 obsolete attachments)

Integration test to open tab tray
Assignee: nobody → nhirata.bugzilla
Created attachment 801642 [details]
git pull 12041

https://github.com/mozilla-b2g/gaia/pull/12041
Flags: needinfo?(bfrancis)
Naoki,

It looks like you created a branch in the main gaia repo for your patch. That's a bad idea.  Hundreds of gaia developers will download your patch the next time the do a 'git pull upstream'.

Instead, you need to make a personal fork of the repo. Then you can create whatever branches you need in that private fork, and create pull requests of of that fork.
I've deleted this branch on mozilla-b2g.

$ git push origin :bug914179
To git@github.com:mozilla-b2g/gaia.git
 - [deleted]         bug914179
Created attachment 802110 [details] [diff] [review]
naokis-patch.diff

This is a copy of your patch before it was removed from mozilla-b2g/gaia.git
Created attachment 802377 [details]
12075.html

new pull request
Attachment #802377 - Flags: review?(bfrancis)
Comment on attachment 802377 [details]
12075.html

This test times out for my on my desktop machine, but passes on my laptop. It seems to pass on Travis so Dale is going to test it and check that it passes for him too. It may just be a problem with my desktop because I'm seeing other tests fail too.

Otherwise the code looks great. If it passes for Dale then please rebase this to squash it into one commit before landing.
Attachment #802377 - Flags: review?(bfrancis) → review+
Flags: needinfo?(bfrancis) → needinfo?(dale)
There's some comments from James on the github repo that I will fix up.
Hey Naoki, when you fix up the comments on github could you rebase this and r? me on it and will take a look to get it merged, apologies for the delay (and thanks for the test)
Flags: needinfo?(dale)
Whiteboard: sprintready

Comment 9

4 years ago
A Pivotal Tracker story has been created for this Bug: http://www.pivotaltracker.com/story/show/57485470
Turns out that I need to change the test so that the test result of a failure will show.  The current will not show a result if it fails, and the pass will never show.
Created attachment 813679 [details]
12041.html
Attachment #801642 - Attachment is obsolete: true
Attachment #802377 - Attachment is obsolete: true
Comment on attachment 813679 [details]
12041.html

It's been rebased.
Attachment #813679 - Flags: review?(dale)
Attachment #813679 - Flags: review?(dale)
Attachment #813679 - Flags: review?(dale)
Sorry for the delay, was on PTO, will rebase and test this one myself, cheers
Comment on attachment 813679 [details]
12041.html

Again very sorry for the delay

I would have fixed this up, but it doesnt work for a few reasons

It is not based off gaia master, to fix this I would just make a new branch based off master and apply your changes manually

The commit mesage needs to be meaningful, "Bug 914179 - Add integration test for opening tab screen" for example.

But the biggest problem is that it doesnt test anything, |(client.helper.waitForElement('#tabs-list')| is always in the dom and will pass irregardless of whats happened, you can tell that by either commenting out subject.tabsBadge.click() or the event listener added in browser.js, it passes both times, it needs to test for visibility
Attachment #813679 - Flags: review?(dale) → review-
I had it right the first time around, I guess I shouldn't have changed it...
In any cases, since we're going to be moving the settings in 1.4; this test case is obsolete so I'm just going to close it.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → WONTFIX
er, I mean there won't be a tab tray ( as well as settings )
Whiteboard: sprintready
You need to log in before you can comment on or make changes to this bug.