914235 - /builds/watch_devices.sh not cleaning up disabled.flg files on foopy

Status: RESOLVED FIXED

(Release Engineering :: General, defect)

Description

[Pete Moore [:pmoore][:pete]]

Since slavealloc became the home for defining which (mobile) devices are disabled, the disabled.flg file became a trigger to stop buildbot, which would be cleaned up after doing this.

In other words, the file is short lived - if you want to disable a device, you change the status in slavealloc to disabled, and then to propagate this change to the device itself, you would create the disabled.flg file in the /builds/<device> directory of the associated foopy. The existence of this file would cause /builds/watch_devices.sh to bring down the buildbot slave on the foopy. The /builds/watch_devices.sh script is called by cron every 5 minutes (see /etc/cron.d/foopy on the foopies).

Therefore this disabled.flg file should only "live" between the time it is manually created, and the time it takes the cron job to bring down buildbot and delete the file.

However, there are several disabled.flg files that are long lived, that are not getting deleted from the foopies. This is because there are edge cases where the "rm" command was not called.

Comment 1

[Pete Moore [:pmoore][:pete]]

Attachment: bug914235.patch

I've attached a patch that should fix this problem. Please note this patch also fixes the code indentation.

Comment 2

[Pete Moore [:pmoore][:pete]]

Committed and pushed: https://hg.mozilla.org/build/tools/rev/a3caad149279

Comment 3

[Pete Moore [:pmoore][:pete]]

This is correctly working in production, closing out bug.