Closed Bug 914245 Opened 12 years ago Closed 12 years ago

move FORCE_SHARED_LIB to mozbuild

Categories

(Firefox Build System :: General, defect)

Product:
Firefox Build System
Component:
General
Platform:
x86_64
Linux
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
mozilla28

People

(Reporter: joey, Assigned: glandium)

References

(Blocks 1 open bug)

Details

(Whiteboard: [qa-])

Attachments

(1 file, 3 obsolete files)

Move FORCE_SHARED_LIB to moz.build.
50.69 KB, patch
mshal
: review+
Details | Diff | Splinter Review
% find . -name 'Makefile.in' | xargs grep FORCE_SHARED_LIB ./gfx/angle/src/libGLESv2/Makefile.in:FORCE_SHARED_LIB = 1 ./gfx/angle/src/libEGL/Makefile.in:FORCE_SHARED_LIB = 1 ./js/src/Makefile.in:FORCE_SHARED_LIB = 1 ./js/xpconnect/tests/components/native/Makefile.in:FORCE_SHARED_LIB = 1 ./layout/media/Makefile.in:FORCE_SHARED_LIB = 1 ./mozglue/build/Makefile.in:FORCE_SHARED_LIB = 1 ./mozglue/build/Makefile.in:ifeq (1_1,$(MOZ_MEMORY)_$(or $(MOZ_NATIVE_JEMALLOC),$(FORCE_SHARED_LIB))) ./mozglue/build/Makefile.in:ifdef FORCE_SHARED_LIB ./extensions/gnomevfs/Makefile.in:FORCE_SHARED_LIB= 1 ./extensions/widgetutils/src/Makefile.in:FORCE_SHARED_LIB = 1 ./db/sqlite3/src/Makefile.in:FORCE_SHARED_LIB = 1 ./accessible/public/msaa/Makefile.in:FORCE_SHARED_LIB = 1 ./accessible/public/ia2/Makefile.in:FORCE_SHARED_LIB = 1 ./xpcom/tests/component_no_aslr/Makefile.in:FORCE_SHARED_LIB = 1 ./xpcom/tests/component/Makefile.in:FORCE_SHARED_LIB = 1 ./xpcom/tests/bug656331_component/Makefile.in:FORCE_SHARED_LIB = 1 ./memory/mozalloc/Makefile.in:FORCE_SHARED_LIB= 1 ./memory/replace/dmd/Makefile.in:FORCE_SHARED_LIB= 1 ./memory/replace/dummy/Makefile.in:FORCE_SHARED_LIB = 1 ./memory/replace/jemalloc/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/system/dbus/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/system/gnome/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/library/winvccorlib/Makefile.in:FORCE_SHARED_LIB=1 ./toolkit/library/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/crashreporter/test/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/crashreporter/injector/Makefile.in:FORCE_SHARED_LIB = 1 ./toolkit/components/ctypes/tests/Makefile.in:FORCE_SHARED_LIB = 1 ./tools/jprof/stub/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/gb235/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/froyo/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/gb235/libstagefright/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/froyo/libstagefright/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/ics/libutils/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/ics/libstagefright/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/gb/libutils/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/gb/libstagefright_color_conversion/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/gb/libstagefright/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/lib/hc/libstagefright/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/gb/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/hc/Makefile.in:FORCE_SHARED_LIB = 1 ./media/omx-plugin/Makefile.in:FORCE_SHARED_LIB = 1 ./build/win32/vmwarerecordinghelper/Makefile.in:FORCE_SHARED_LIB = 1 ./build/win32/crashinjectdll/Makefile.in:FORCE_SHARED_LIB = 1 ./security/build/Makefile.in:FORCE_SHARED_LIB = 1 ./dom/plugins/ipc/interpose/Makefile.in:FORCE_SHARED_LIB = 1 ./browser/components/build/Makefile.in:FORCE_SHARED_LIB = 1
Blocks: nomakefiles
passthrough variable already added, Makefile.in still needs to be converted.
Attachment #832859 - Flags: review?(mshal)
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Blocks: 939068
Attachment #832862 - Flags: review?(mshal)
Attachment #832859 - Attachment is obsolete: true
Attachment #832859 - Flags: review?(mshal)
Attachment #832871 - Flags: review?(mshal)
Attachment #832862 - Attachment is obsolete: true
Attachment #832862 - Flags: review?(mshal)
Comment on attachment 832871 [details] [diff] [review] Move FORCE_SHARED_LIB to moz.build. Breaks js standalone
Attachment #832871 - Flags: review?(mshal)
Attachment #832879 - Flags: review?(mshal)
Attachment #832871 - Attachment is obsolete: true
Comment on attachment 832879 [details] [diff] [review] Move FORCE_SHARED_LIB to moz.build. >diff --git a/gfx/angle/src/libEGL/moz.build b/gfx/angle/src/libEGL/moz.build >--- a/gfx/angle/src/libEGL/moz.build >+++ b/gfx/angle/src/libEGL/moz.build >@@ -16,9 +16,12 @@ SOURCES += ['../common/' + src for src i > SOURCES += [ > 'Config.cpp', > 'Display.cpp', > 'libEGL.cpp', > 'main.cpp', > 'Surface.cpp', > ] > >+# On Windows, we don't automatically get "lib" prepended, but we need it. > LIBRARY_NAME = 'libEGL' Thanks for moving these comments to the correct variable. Looks like I missed that on a previous review :/ >diff --git a/toolkit/library/winvccorlib/Makefile.in b/toolkit/library/winvccorlib/Makefile.in >-# When we're linking GTest we recurse into this directory but don't need >-# to generate this library Not sure if it was intentional, but this comment wasn't carried over to moz.build
Attachment #832879 - Flags: review?(mshal) → review+
https://hg.mozilla.org/mozilla-central/rev/ec4d30f2de51
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla28
Whiteboard: [qa-]
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: