Closed
Bug 914260
Opened 11 years ago
Closed 11 years ago
Add review requirement to the error message in test_interfaces
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: mccr8, Assigned: mccr8)
Details
Attachments
(1 file)
|
1.66 KB,
patch
|
bzbarsky
:
review+
|
Details | Diff | Splinter Review |
I'll get to this in the next day or two, but if somebody else wants to grab it before then, feel free.
|
Assignee | |
Comment 1•11 years ago
|
||
Other ideas discussed in IRC were adding the review requirement to every line, and possibly include the name of the DOM peer who approved that line. Possibly with cryptographic signing of each line. ;)
|
|
Assignee | |
Comment 2•11 years ago
|
||
Attachment #801914 -
Flags: review?(bzbarsky)
|
||
Comment 3•11 years ago
|
||
Comment on attachment 801914 [details] [diff] [review] 914260.patch r=me
Attachment #801914 -
Flags: review?(bzbarsky) → review+
|
|
Assignee | |
Comment 4•11 years ago
|
||
try run: https://tbpl.mozilla.org/?tree=Try&rev=760c1d1023c0
|
|
Assignee | |
Comment 5•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/2b76eb674066
|
||
Comment 6•11 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/2b76eb674066
Status: NEW → RESOLVED
Closed: 11 years ago
Flags: in-testsuite-
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
|
||
Updated•5 years ago
|
Component: DOM → DOM: Core & HTML
You need to log in
before you can comment on or make changes to this bug.
Description
•