Closed
Bug 914262
Opened 12 years ago
Closed 12 years ago
KHTML-based browsers such as Konqueror do not support the Server-Push technology
Categories
(Bugzilla :: Query/Bug List, defect)
Tracking
()
RESOLVED
FIXED
Bugzilla 4.2
People
(Reporter: LpSolit, Assigned: LpSolit)
Details
Attachments
(1 file)
714 bytes,
patch
|
dkl
:
review+
|
Details | Diff | Splinter Review |
Konqueror and other KHTML-based browsers such as Safari do not support the Server-Push technology used in buglists. We already catch Safari correctly thanks to "WebKit" being in its UA string but we totally miss Konqueror. Side-effects are the inability to use the QuickSearch feature more than once in a row (on the 2nd attempt, the QS stops working) and the UI is broken in guided form when filing a new bug, see e.g. https://bugs.gentoo.org/show_bug.cgi?id=380617.
![]() |
Assignee | |
Comment 1•12 years ago
|
||
Attachment #801661 -
Flags: review?(dkl)
Comment 2•12 years ago
|
||
Comment on attachment 801661 [details] [diff] [review]
patch, v1
Review of attachment 801661 [details] [diff] [review]:
-----------------------------------------------------------------
r=dkl
Attachment #801661 -
Flags: review?(dkl) → review+
Updated•12 years ago
|
Flags: approval?
Flags: approval4.4?
![]() |
||
Updated•12 years ago
|
Flags: approval?
Flags: approval4.4?
Flags: approval4.4+
Flags: approval+
![]() |
Assignee | |
Comment 3•12 years ago
|
||
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/trunk/
modified buglist.cgi
Committed revision 8733.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.4/
modified buglist.cgi
Committed revision 8604.
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
![]() |
Assignee | |
Comment 4•12 years ago
|
||
approval4.2 = justdave on IRC.
Committing to: bzr+ssh://lpsolit%40gmail.com@bzr.mozilla.org/bugzilla/4.2/
modified buglist.cgi
Committed revision 8227.
Flags: approval4.2+
Target Milestone: Bugzilla 4.4 → Bugzilla 4.2
Comment on attachment 801661 [details] [diff] [review]
patch, v1
>Index: buglist.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v
>retrieving revision 1.457
>diff -p -u -r1.457 buglist.cgi
>--- buglist.cgi 13 Aug 2013 18:57:12 -0000 1.457
>+++ buglist.cgi 9 Sep 2013 17:08:57 -0000
>@@ -105,7 +105,7 @@ my $serverpush =
> && exists $ENV{'HTTP_USER_AGENT'}
> && $ENV{'HTTP_USER_AGENT'} =~ /(Mozilla.[3-9]|Opera)/
> && $ENV{'HTTP_USER_AGENT'} !~ /compatible/i
>- && $ENV{'HTTP_USER_AGENT'} !~ /(?:WebKit|Trident)/
>+ && $ENV{'HTTP_USER_AGENT'} !~ /(?:WebKit|Trident|KHTML)/
> && !defined($cgi->param('serverpush'))
> || $cgi->param('serverpush');
>
You need to log in
before you can comment on or make changes to this bug.
Description
•