914262 - KHTML-based browsers such as Konqueror do not support the Server-Push technology

Status: RESOLVED FIXED

Description

[Frédéric Buclin]

Konqueror and other KHTML-based browsers such as Safari do not support the Server-Push technology used in buglists. We already catch Safari correctly thanks to "WebKit" being in its UA string but we totally miss Konqueror. Side-effects are the inability to use the QuickSearch feature more than once in a row (on the 2nd attempt, the QS stops working) and the UI is broken in guided form when filing a new bug, see e.g. https://bugs.gentoo.org/show_bug.cgi?id=380617.

Comment 1

[Frédéric Buclin]

Created attachment 801661 [details] [diff] [review]
patch, v1

Comment 2

[David Lawrence [:dkl]]

Comment on attachment 801661 [details] [diff] [review]
patch, v1

Review of attachment 801661 [details] [diff] [review]:
-----------------------------------------------------------------

r=dkl

Comment 3

[Frédéric Buclin]

Committing to: bzr+ssh://[e-mail]/bugzilla/trunk/
modified buglist.cgi
Committed revision 8733.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.4/
modified buglist.cgi
Committed revision 8604.

Comment 4

[Frédéric Buclin]

approval4.2 = justdave on IRC.

Committing to: bzr+ssh://[e-mail]/bugzilla/4.2/
modified buglist.cgi
Committed revision 8227.

Comment 5

[createnew]

Comment on attachment 801661 [details] [diff] [review]
patch, v1

>Index: buglist.cgi
>===================================================================
>RCS file: /cvsroot/mozilla/webtools/bugzilla/buglist.cgi,v
>retrieving revision 1.457
>diff -p -u -r1.457 buglist.cgi
>--- buglist.cgi	13 Aug 2013 18:57:12 -0000	1.457
>+++ buglist.cgi	9 Sep 2013 17:08:57 -0000
>@@ -105,7 +105,7 @@ my $serverpush =
>     && exists $ENV{'HTTP_USER_AGENT'} 
>       && $ENV{'HTTP_USER_AGENT'} =~ /(Mozilla.[3-9]|Opera)/
>         && $ENV{'HTTP_USER_AGENT'} !~ /compatible/i
>-          && $ENV{'HTTP_USER_AGENT'} !~ /(?:WebKit|Trident)/
>+          && $ENV{'HTTP_USER_AGENT'} !~ /(?:WebKit|Trident|KHTML)/
>             && !defined($cgi->param('serverpush'))
>               || $cgi->param('serverpush');
>