Closed
Bug 914273
Opened 11 years ago
Closed 11 years ago
move JS_MODULES_PATH to mozbuild
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla27
People
(Reporter: joey, Assigned: Cykesiopka)
References
(Blocks 1 open bug)
Details
Attachments
(1 file)
|
2.20 KB,
patch
|
joey
:
review+
|
Details | Diff | Splinter Review |
passthrough variable support already added % find . -name "Makefile.in" | xargs grep JS_MODULES_PATH ./services/metrics/Makefile.in:JS_MODULES_PATH = modules/services/metrics ./services/common/Makefile.in:PP_JS_MODULES_PATH = $(FINAL_TARGET)/modules/services-common
|
Reporter | |
Updated•11 years ago
|
Blocks: nomakefiles
|
Assignee | |
Comment 1•11 years ago
|
||
Attachment #807889 -
Flags: review?(joey)
|
|
Reporter | |
Comment 2•11 years ago
|
||
Comment on attachment 807889 [details] [diff] [review] bug914273_v1.patch Review of attachment 807889 [details] [diff] [review]: ----------------------------------------------------------------- Patch looks good. Excluding services/common/Makefile.in was also a plus, that should be part of a separate conversion. ./services/common/Makefile.in:PP_JS_MODULES_PATH = $(FINAL_TARGET)/modules/services-common
Attachment #807889 -
Flags: review?(joey) → review+
|
|
Assignee | |
Updated•11 years ago
|
Assignee: nobody → cykesiopka.bmo
Keywords: checkin-needed
|
||
Comment 3•11 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/c3c92964e23f
Flags: in-testsuite-
Keywords: checkin-needed
https://hg.mozilla.org/mozilla-central/rev/c3c92964e23f
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
|
||
Updated•6 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•