914327 - B2G mach target should handle test_path better

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Andrew Halberstadt [:ahal]]

Right now the mochitest mach target for b2g just passes in the value of test_path to --test-path in the mochitest harness. This means you need to be very specific about the value you use, making running individual tests or directories unintuitive.

The desktop version of the mochitest mach command does some checks so absolute paths, directories, etc.. can also be used. The b2g command should follow suit.

Comment 1

[Andrew Halberstadt [:ahal]]

Attachment: mochitest_commands

I wanted to move some of the shared logic into the constructor, but the MozbuildObject._spawn() method requires the MochitestRunner class to have the same signature, and it was only one or two lines anyway so decided against a helper method.

Comment 2

[Jonathan Griffin (:jgriffin)]

Comment on attachment 802567 [details] [diff] [review]
mochitest_commands

Review of attachment 802567 [details] [diff] [review]:
-----------------------------------------------------------------

Nice, thanks.

Comment 3

[Andrew Halberstadt [:ahal]]

https://hg.mozilla.org/integration/b2g-inbound/rev/db0a833aee39

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/db0a833aee39