Closed Bug 914369 Opened 9 years ago Closed 9 years ago

Better client side debugging of push notifications

Categories

(Core :: DOM: Push Notifications, defect)

x86_64
Linux
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla27

People

(Reporter: nsm, Assigned: nsm)

Details

Attachments

(1 file)

It should be easy for a user/developer to peek into the websocket message stream. It is often hard to tell whether the push notification socket has failed, or the server isn't forwarding the notification or the system isn't waking up the app. Right now the debug flags are set at compile time in gecko. There should be an option in developer settings to toggle this at runtime.
Assignee: nobody → nsm.nikhil
Comment on attachment 805603 [details] [diff] [review]
Add SimplePush debug pref.

Review of attachment 805603 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +400,5 @@
>  
>  // SimplePush
>  pref("services.push.enabled", true);
> +// Debugging enabled.
> +pref("services.push.debug.enabled", false);

just name this 'services.push.debug'.  If you look at other prefs, more 'enable debugging' preference name end in '.debug'.

::: dom/push/src/Push.js
@@ +4,5 @@
>  
>  "use strict";
>  
> +// Don't modify this, instead set services.push.debug.enabled.
> +let DEBUG = false;

s/DEBUG/gDebuggingEnabled
Attachment #805603 - Flags: review?(doug.turner) → review+
https://hg.mozilla.org/mozilla-central/rev/a0ec683fa042
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.