914369 - Better client side debugging of push notifications

Status: RESOLVED FIXED

(Core :: DOM: Push Subscriptions, defect)

Description

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

It should be easy for a user/developer to peek into the websocket message stream. It is often hard to tell whether the push notification socket has failed, or the server isn't forwarding the notification or the system isn't waking up the app. Right now the debug flags are set at compile time in gecko. There should be an option in developer settings to toggle this at runtime.

Comment 1

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

Attachment: Add SimplePush debug pref.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 805603 [details] [diff] [review]
Add SimplePush debug pref.

Review of attachment 805603 [details] [diff] [review]:
-----------------------------------------------------------------

::: b2g/app/b2g.js
@@ +400,5 @@
>  
>  // SimplePush
>  pref("services.push.enabled", true);
> +// Debugging enabled.
> +pref("services.push.debug.enabled", false);

just name this 'services.push.debug'.  If you look at other prefs, more 'enable debugging' preference name end in '.debug'.

::: dom/push/src/Push.js
@@ +4,5 @@
>  
>  "use strict";
>  
> +// Don't modify this, instead set services.push.debug.enabled.
> +let DEBUG = false;

s/DEBUG/gDebuggingEnabled

Comment 3

[Nikhil Marathe [:nsm] (No longer reading bugmail, please needinfo?)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/a0ec683fa042

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/a0ec683fa042