Closed Bug 914374 Opened 7 years ago Closed 7 years ago

Intermittent Android Armv6 build failure due to "make[3]: *** [make-package-internal] Error 139" after segfaulting

Categories

(Core :: mozglue, defect)

ARM
Android
defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26
Tracking Status
firefox24 --- unaffected
firefox25 --- fixed
firefox26 --- fixed

People

(Reporter: RyanVM, Assigned: glandium)

Details

(Keywords: intermittent-failure)

Attachments

(1 file)

And for today's Android build bustage...

https://tbpl.mozilla.org/php/getParsedLog.php?id=27591963&tree=Mozilla-Inbound

Android Armv6 mozilla-inbound build on 2013-09-09 11:50:57 PDT for push 12d7c0e889d1
slave: bld-linux64-ec2-155

Packaging JavaScript Shell...
rm -f ../../../dist/jsshell-android-arm-armv6.zip
/usr/bin/zip -9j ../../../dist/jsshell-android-arm-armv6.zip ../../../dist/bin/js ../../../dist/bin/libmozglue.so  ../../../dist/bin/libnss3.so
  adding: js (deflated 59%)
  adding: libmozglue.so (deflated 63%)
  adding: libnss3.so (deflated 61%)
/builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/config/nsinstall -D ../../../dist/
/builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/_virtualenv/bin/python /builds/slave/m-in-and-a6-000000000000000000/build/toolkit/mozapps/installer/informulate.py \
		../../../dist//fennec-26.0a1.en-US.android-arm-armv6.json \
		BUILDID=20130909114553 \
		MOZ_SOURCE_REPO=http://hg.mozilla.org/integration/mozilla-inbound \
		MOZ_SOURCE_STAMP=12d7c0e889d1 \
		MOZ_PKG_PLATFORM=android-arm-armv6
Compressing...
cd ../../../dist && host/bin/szip -D auto -f auto fennec/assets/libmozalloc.so &&  host/bin/szip -D auto -f auto fennec/assets/libnss3.so &&  host/bin/szip -D auto -f auto fennec/assets/libxul.so &&  host/bin/szip -D auto -f auto fennec/assets/libnssckbi.so &&  host/bin/szip -D auto -f auto fennec/assets/libfreebl3.so &&  host/bin/szip -D auto -f auto fennec/assets/libsoftokn3.so &&  host/bin/szip -D auto -f auto fennec/assets/libomxplugin.so &&  host/bin/szip -D auto -f auto fennec/assets/libomxplugingb.so &&  host/bin/szip -D auto -f auto fennec/assets/libomxplugingb235.so &&  host/bin/szip -D auto -f auto fennec/assets/libomxpluginhc.so &&  host/bin/szip -D auto -f auto fennec/assets/libomxpluginfroyo.so &&  make -C /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../mobile/android/base gecko.ap_ && cp /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../mobile/android/base/gecko.ap_ /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist && ( cd fennec && mkdir -p lib/armeabi && mv libmozglue.so lib/libplugin-container.so lib/armeabi && unzip -o /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ && rm /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ && /usr/bin/zip -0 /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ assets/libmozalloc.so assets/libnss3.so assets/libxul.so assets/libnssckbi.so assets/libfreebl3.so assets/libsoftokn3.so assets/libomxplugin.so assets/libomxplugingb.so assets/libomxplugingb235.so assets/libomxpluginhc.so assets/libomxpluginfroyo.so && /usr/bin/zip -r9D /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ resources.arsc AndroidManifest.xml chrome components defaults modules hyphenation res lib extensions application.ini package-name.txt platform.ini greprefs.js browserconfig.properties blocklist.xml chrome.manifest update.locale removed-files recommended-addons.json distribution -x classes.dex  libmozglue.so lib/libplugin-container.so assets/libmozalloc.so assets/libnss3.so assets/libxul.so assets/libnssckbi.so assets/libfreebl3.so assets/libsoftokn3.so assets/libomxplugin.so assets/libomxplugingb.so assets/libomxplugingb235.so assets/libomxpluginhc.so assets/libomxpluginfroyo.so assets/libmozalloc.so assets/libnss3.so assets/libxul.so assets/libnssckbi.so assets/libfreebl3.so assets/libsoftokn3.so assets/libomxplugin.so assets/libomxplugingb.so assets/libomxplugingb235.so assets/libomxpluginhc.so assets/libomxpluginfroyo.so &&  mkdir -p assets/ && mv omni.ja assets/ &&  /usr/bin/zip -0 /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ assets/omni.ja) && rm -f /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk && cp /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.ap_ /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk && /usr/bin/zip -j0 /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk fennec/classes.dex && cp /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko-unsigned-unaligned.apk && python /builds/slave/m-in-and-a6-000000000000000000/tools/release/signing/signtool.py --cachedir /builds/slave/m-in-and-a6-000000000000000000/signing_cache -t /builds/slave/m-in-and-a6-000000000000000000/token -n /builds/slave/m-in-and-a6-000000000000000000/nonce -c /builds/slave/m-in-and-a6-000000000000000000/tools/release/signing/host.cert -H signing4.srv.releng.scl3.mozilla.com:9110 -H signing5.srv.releng.scl3.mozilla.com:9110 -H signing6.srv.releng.scl3.mozilla.com:9110 -f jar /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk && /builds/slave/m-in-and-a6-000000000000000000/build/android-sdk-linux/platforms/android-16/../../tools/zipalign -f -v 4 /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/gecko.apk fennec-26.0a1.en-US.android-arm-armv6.apk && /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/config/nsinstall /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../mobile/android/base/fennec_ids.txt /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist && cp /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/../build/mobile/robocop/robocop-debug-unsigned-unaligned.apk /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/robocop-unaligned.apk && python /builds/slave/m-in-and-a6-000000000000000000/tools/release/signing/signtool.py --cachedir /builds/slave/m-in-and-a6-000000000000000000/signing_cache -t /builds/slave/m-in-and-a6-000000000000000000/token -n /builds/slave/m-in-and-a6-000000000000000000/nonce -c /builds/slave/m-in-and-a6-000000000000000000/tools/release/signing/host.cert -H signing4.srv.releng.scl3.mozilla.com:9110 -H signing5.srv.releng.scl3.mozilla.com:9110 -H signing6.srv.releng.scl3.mozilla.com:9110 -f jar /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/robocop-unaligned.apk && /builds/slave/m-in-and-a6-000000000000000000/build/android-sdk-linux/platforms/android-16/../../tools/zipalign -f -v 4 /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/robocop-unaligned.apk /builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer/../../../dist/robocop.apk && make -C ../mobile/android/geckoview_library package ABI_DIR=armeabi
Size = 4528
Compressed size is 1975
Size = 2228428
Compressed size is 964318
Size = 31358980
/bin/sh: line 1:  5629 Segmentation fault      (core dumped) host/bin/szip -D auto -f auto fennec/assets/libxul.so
make[3]: *** [make-package-internal] Error 139
make[3]: Leaving directory `/builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer'
make[2]: Leaving directory `/builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer'
make[2]: *** [make-package] Error 2
make[1]: *** [default] Error 2
make[1]: Leaving directory `/builds/slave/m-in-and-a6-000000000000000000/build/obj-firefox/mobile/android/installer'
make: *** [package] Error 2
State Changed: unlock buildroot
program finished with exit code 2
This is due to a buffer overflow in BCJ_X86_filter (yes, we try it anyways on arm builds) when the buffer it is given is too small. It is only triggered when the size of the szipped file % 16k is less than 5.
Component: Build Config → mozglue
Assignee: nobody → mh+mozilla
Status: NEW → ASSIGNED
Attachment #801990 - Flags: review?(nfroyd) → review+
https://hg.mozilla.org/mozilla-central/rev/5e8290749d60
Status: ASSIGNED → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
I assume you'll request Aurora approval on this, Mike?
Comment on attachment 801990 [details] [diff] [review]
Fix buffer overflow in BCJ_X86_filter when the given buffer is too small

[Approval Request Comment]
Bug caused by (feature/regressing bug #): bug 848773 added the code that's faulty, and bug 848764 enables its use.
User impact if declined: Failures to build if library sizes are between 1 and 5 bytes larger than a multiple of 16K.
Testing completed (on m-c, etc.): validated locally with a failed build. Landed on m-c today.
Risk to taking this patch (and alternatives if risky): Low risk. The patch is straightforward.
String or IDL/UUID changes made by this patch: None
Attachment #801990 - Flags: approval-mozilla-aurora?
Comment on attachment 801990 [details] [diff] [review]
Fix buffer overflow in BCJ_X86_filter when the given buffer is too small

death to intermittent failures
Attachment #801990 - Flags: approval-mozilla-aurora? → approval-mozilla-aurora+
You need to log in before you can comment on or make changes to this bug.