South hijacking the test command

RESOLVED FIXED

Status

Webtools
Elmo
RESOLVED FIXED
5 years ago
4 years ago

People

(Reporter: peterbe, Assigned: peterbe)

Tracking

Trunk
x86
Mac OS X

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 1 obsolete attachment)

(Assignee)

Description

5 years ago
Since we added south to INSTALLED_APPS now we can't do things like `./manage.py test -s -x` since those aren't recognized arguments. When django-nose takes over `test` it passes on all other arguments to nosetests.
(Assignee)

Comment 1

5 years ago
Created attachment 801873 [details] [diff] [review]
bug914389.diff

Now `./manage.py test -s -x` works again :)
Attachment #801873 - Flags: review?(l10n)

Comment 2

5 years ago
Comment on attachment 801873 [details] [diff] [review]
bug914389.diff

Review of attachment 801873 [details] [diff] [review]:
-----------------------------------------------------------------

I'm torn on this one.

Should we just drop re-using the funfactory INSTALLED_APPS? One third of the apps there are actually just baggage for us, and they're in the wrong order.

It'd also reduce the review surface when taking updates to vendor.

r=me if just taking our own list doesn't make sense.

::: settings/base.py
@@ +120,5 @@
> +INSTALLED_APPS = list(INSTALLED_APPS)
> +INSTALLED_APPS.remove('django_nose')
> +INSTALLED_APPS.append('django_nose')
> +INSTALLED_APPS = tuple(INSTALLED_APPS)
> +

tuple(sorted(INSTALLED_APPS, key=lambda app: app=='django_nose'))

does the same thing, fwiw.
Attachment #801873 - Flags: review?(l10n) → review+
(Assignee)

Comment 3

5 years ago
Created attachment 802486 [details] [diff] [review]
bug914389-3.diff

A more explicit list.
Attachment #801873 - Attachment is obsolete: true
Attachment #802486 - Flags: review?(l10n)

Updated

5 years ago
Attachment #802486 - Flags: review?(l10n) → review+

Comment 4

5 years ago
Commit pushed to develop at https://github.com/mozilla/elmo

https://github.com/mozilla/elmo/commit/85285865889a8b124bc2e21726487de7d91409a3
fixes bug 914389 - South hijacking the test command, r=Pike

Updated

5 years ago
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED

Updated

4 years ago
Assignee: nobody → peterbe
You need to log in before you can comment on or make changes to this bug.