Closed
Bug 914411
Opened 10 years ago
Closed 10 years ago
Option to force mach build to build with pymake
Categories
(Firefox Build System :: General, defect)
Firefox Build System
General
Tracking
(Not tracked)
RESOLVED
FIXED
mozilla26
People
(Reporter: gps, Assigned: gps)
Details
Attachments
(1 file)
6.75 KB,
patch
|
glandium
:
review+
|
Details | Diff | Splinter Review |
I'm finding myself running pymake a lot on non-Windows and would like the ability to force mach to build with pymake instead of using its current sniff-platform-only behavior. Patch in a few seconds...
Assignee | ||
Comment 1•10 years ago
|
||
Attachment #801909 -
Flags: review?(mh+mozilla)
Assignee | ||
Updated•10 years ago
|
Assignee: nobody → gps
Comment 2•10 years ago
|
||
Comment on attachment 801909 [details] [diff] [review] Option to force mach build to use pymake Review of attachment 801909 [details] [diff] [review]: ----------------------------------------------------------------- ::: python/mozbuild/mozbuild/mach_commands.py @@ +283,5 @@ > @CommandArgument('--jobs', '-j', default='0', metavar='jobs', type=int, > help='Number of concurrent jobs to run. Default is the number of CPUs.') > @CommandArgument('what', default=None, nargs='*', help=BUILD_WHAT_HELP) > + @CommandArgument('-p', '--pymake', action='store_true', > + help='Force using pymake over GNU make.') Not sure this needs to be publicly exposed. It's likely only useful for you and I (I've also been doing a lot of pymake runs on linux lately)
Attachment #801909 -
Flags: review?(mh+mozilla) → review+
Assignee | ||
Comment 3•10 years ago
|
||
https://hg.mozilla.org/integration/mozilla-inbound/rev/32e968bcba07 Yeah, I agree the utility is low. We can always remove it if the cost of maintaining becomes too high.
Status: NEW → ASSIGNED
Flags: in-testsuite-
Comment 4•10 years ago
|
||
https://hg.mozilla.org/mozilla-central/rev/32e968bcba07
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Updated•5 years ago
|
Product: Core → Firefox Build System
You need to log in
before you can comment on or make changes to this bug.
Description
•