914411 - Option to force mach build to build with pymake

Status: RESOLVED FIXED

Description

[Gregory Szorc [:gps]]

I'm finding myself running pymake a lot on non-Windows and would like the ability to force mach to build with pymake instead of using its current sniff-platform-only behavior. Patch in a few seconds...

Comment 1

[Gregory Szorc [:gps]]

Created attachment 801909 [details] [diff] [review]
Option to force mach build to use pymake

Comment 2

[Mike Hommey [:glandium]]

Comment on attachment 801909 [details] [diff] [review]
Option to force mach build to use pymake

Review of attachment 801909 [details] [diff] [review]:
-----------------------------------------------------------------

::: python/mozbuild/mozbuild/mach_commands.py
@@ +283,5 @@
>      @CommandArgument('--jobs', '-j', default='0', metavar='jobs', type=int,
>          help='Number of concurrent jobs to run. Default is the number of CPUs.')
>      @CommandArgument('what', default=None, nargs='*', help=BUILD_WHAT_HELP)
> +    @CommandArgument('-p', '--pymake', action='store_true',
> +        help='Force using pymake over GNU make.')

Not sure this needs to be publicly exposed. It's likely only useful for you and I (I've also been doing a lot of pymake runs on linux lately)

Comment 3

[Gregory Szorc [:gps]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/32e968bcba07

Yeah, I agree the utility is low. We can always remove it if the cost of maintaining becomes too high.

Comment 4

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/32e968bcba07