914476 - mozilla-python27 RPM package should symlink python -> python2.7 binary

Status: RESOLVED FIXED

(Infrastructure & Operations Graveyard :: CIDuty, task)

Description

[John Hopkins (:jhopkins)]

Our mozilla-python27 package does not symlink python -> python2.7 which breaks scripts that use a shebang line referencing 'python':

#!/usr/bin/env python

Contents of current package's bin directory:

# ls -l /tools/python27/bin/
total 44
-rwxr-xr-x 1 root root   106 Apr 10 12:39 2to3
-rwxr-xr-x 1 root root   104 Apr 10 12:39 idle
-rwxr-xr-x 1 root root    89 Apr 10 12:39 pydoc
-rwxr-xr-x 1 root root  4896 Apr 10 12:40 python2.7
-rwxr-xr-x 1 root root  1629 Apr 10 12:39 python2.7-config
-rwxr-xr-x 1 root root 18552 Apr 10 12:39 smtpd.py

Comment 1

[John Hopkins (:jhopkins)]

Attachment: [puppet] updated mozilla-python27 RPM spec file which creates a symlink from python->python2.7

Comment 2

[Justin Wood (:Callek)]

Comment on attachment 802540 [details] [diff] [review]
[puppet] updated mozilla-python27 RPM spec file which creates a symlink from python->python2.7

Review of attachment 802540 [details] [diff] [review]:
-----------------------------------------------------------------

::: modules/packages/manifests/mozilla/python27.spec
@@ +62,2 @@
>  ln -s %{_prefix}/bin/python%{pyver} $RPM_BUILD_ROOT/usr/local/bin/python%{pyver}
> +ln -s %{_prefix}/bin/python%{pyver} $RPM_BUILD_ROOT%{_prefix}/bin/python

Nit: Can you move this symlink above to just under the make call, the comment here and the other ln -s confused me at first.

Comment 3

[John Hopkins (:jhopkins)]

Comment on attachment 802540 [details] [diff] [review]
[puppet] updated mozilla-python27 RPM spec file which creates a symlink from python->python2.7

Deployed packages to yum repo.  I've left the patch nits for now as I wanted to to avoid another build/test cycle.

Spec file submitted in:
 https://hg.mozilla.org/build/puppet/rev/05aea507cd59

Comment 4

[John Hopkins (:jhopkins)]

Triggered mock scrub in https://hg.mozilla.org/build/puppet/rev/908cf7da1358

Comment 5

[John Hopkins (:jhopkins)]

Also bumped $repoflag to trigger a yum cache clear in https://hg.mozilla.org/build/puppet/rev/5ccca7162034

Comment 6

[John Hopkins (:jhopkins)]

I'm seeing green builds with the new package.