914493 - [Email] iframe is not resized for the embedded images that were already downloaded while building body

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::E-Mail, defect)

Description

[Leo]

STR:
1. Create an IMAP account.
2. Receive an email with large bmp image as inline image
3. Message box -> Open the Email -> click to down load the line image
4. Downloaded image shows with scroll bars.
5. Go back
6. Again open the same email

Result: 
Image is not displayed completely 

Expected: 
Image should be displayed with proper scrolling.

Note:
1.Issue reproduced with gaia v1-train.

Comment 1

[psingapati]

Attachment: Test Image

Test image with which issue reproduces.
Add the attached image as inline and send.
Open the email from FxOS device.

Comment 2

[psingapati]

Attachment: Bug_914493.patch

Andrew,

The attached patch has fix for resizing the iframe for embedded images, when we are building body.
Please review and provide feedback.

Thanks.

Comment 3

[Andrew Sutherland [:asuth] (he/him)]

Attachment: Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12059

Pointer to Github pull-request

Comment 4

[Andrew Sutherland [:asuth] (he/him)]

Comment on attachment 802158 [details]
Pointer to Github pull request: https://github.com/mozilla-b2g/gaia/pull/12059

r=asuth.  I'll land this once it's clear there are no Travis surprises.

Currently skipping unit tests since the tests are about two orders of magnitude more complex than the fix and the fix is a logical consistency issue.  (Use a callback in the other places we use a callback).  For the 1.3 cycle I believe we are planning to fix the message display mechanism which is when I expect us to address the test deficit.

psingapati, if you can mark the bug leo+, I can land this on v1-train for you too.

Comment 5

[psingapati]

Thanks for r+.

made leo+, please land it on v1-train.

Thanks

Comment 6

[Andrew Sutherland [:asuth] (he/him)]

Landed on gaia/master:
https://github.com/mozilla-b2g/gaia/pull/12059
https://github.com/mozilla-b2g/gaia/commit/ee8f269603d0ddfd7a25e1eb10c0ce31b3389a37

Landed on gaia/v1-train:
https://github.com/mozilla-b2g/gaia/pull/12060
https://github.com/mozilla-b2g/gaia/commit/946623575b3fbf6138fff5f77ddead3cadffacce

Comment 7

[Tim Guan-tin Chien [:timdream] (please needinfo)]

v1.1.0hd: 946623575b3fbf6138fff5f77ddead3cadffacce
v1.1.0hd: f73489abba922237dcf7ff0c52df2a972bc59b78