Closed Bug 914505 Opened 9 years ago Closed 9 years ago

Make sure that ThebesLayerBuffer::SupportsAzureContent is correct for the first frame

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: mattwoodrow, Unassigned)

References

Details

Attachments

(1 file, 1 obsolete file)

No description provided.
Attached patch WIP (obsolete) — Splinter Review
Builds, will try find time later on tonight to get some testing done.
Attached patch FixSplinter Review
https://tbpl.mozilla.org/?tree=Try&rev=44c0bbc8bf58

Looks like we're ok, and this fixed the rest of my b2g reftest failures.
Attachment #802803 - Flags: review?(ncameron)
Attachment #802088 - Attachment is obsolete: true
Comment on attachment 802803 [details] [diff] [review]
Fix

Review of attachment 802803 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/layers/ThebesLayerBuffer.h
@@ +246,5 @@
>    /**
>     * Return a new surface of |aSize| and |aType|.
>     * @param aFlags if ALLOW_REPEAT is set, then the buffer should be configured
>     * to allow repeat-mode, otherwise it should be in pad (clamp) mode
>     */

please comment on the out params

@@ +249,5 @@
>     * to allow repeat-mode, otherwise it should be in pad (clamp) mode
>     */
> +  virtual void
> +  CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +               gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,

nit: space after comma

::: gfx/layers/client/ContentClient.h
@@ +152,5 @@
>      ThebesLayerBuffer::DrawTo(aLayer, aTarget, aOpacity, aMask, aMaskTransform);
>    }
>  
> +  virtual void CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +                            gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,

nit: space after comma

@@ +153,5 @@
>    }
>  
> +  virtual void CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +                            gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,
> +                            RefPtr<gfx::DrawTarget>* aBlackDT, RefPtr<gfx::DrawTarget>* aWhiteDT);

MOZ_OVERRIDE

@@ +233,5 @@
>      return ThebesLayerBuffer::BufferRotation();
>    }
>  
> +  virtual void CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +                            gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,

nit again

@@ +234,5 @@
>    }
>  
> +  virtual void CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +                            gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,
> +                            RefPtr<gfx::DrawTarget>* aBlackDT, RefPtr<gfx::DrawTarget>* aWhiteDT);

MOZ_OVERRIDE

::: gfx/layers/opengl/ThebesLayerOGL.cpp
@@ +357,5 @@
>  
>    // ThebesLayerBuffer interface
> +  void
> +  CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +               gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,

nit: space after comma

@@ +358,5 @@
>    // ThebesLayerBuffer interface
> +  void
> +  CreateBuffer(ContentType aType, const nsIntRect& aRect, uint32_t aFlags,
> +               gfxASurface** aBlackSurface,gfxASurface** aWhiteSurface,
> +               RefPtr<gfx::DrawTarget>* aBlackDT, RefPtr<gfx::DrawTarget>* aWhiteDT)

MOZ_OVERRIDE
Attachment #802803 - Flags: review?(ncameron) → review+
Blocks: 907463
https://hg.mozilla.org/mozilla-central/rev/771e3bbcd721
Status: NEW → RESOLVED
Closed: 9 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.