Closed Bug 914508 Opened 6 years ago Closed 6 years ago

Remove more stuff out of inlines.h/-inl.h files, and remove some unnecessary #include statements.

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: njn, Assigned: njn)

Details

Attachments

(1 file)

More ice-cream and merry-go-rounds.
Sorry, I accidentally combined two distinct patches and was too lazy to
disentangle them.  What's going on here:

- I removed a bunch of unnecessary header inclusions, mostly inlines.h/-inl.h
  ones, as identified by IWYU.  Due to pre-existing bootlegging, some new
  #include statements had to be added.

- I moved some stuff out of gc/Barrier-inl.h, jsobjinlines.h, vm/Runtime-inl.h,
  and vm/RegExpStatics-inl.h;  the last of these was removed entirely.
  
  If you're wondering why RegExpStatics::markFlagsSet() ended up in
  RegExpStatics.cpp, note that in RegExpStatics.h it was declared as
  non-inline, but in RegExpStatics-inl.h it was declared inline.  I've seen
  this kind of mismatch on quite a few functions that I've moved out of -inl.h
  files recently.
Attachment #802090 - Flags: review?(terrence)
Comment on attachment 802090 [details] [diff] [review]
Remove more stuff out of inlines.h/-inl.h files, and remove some unnecessary #include statements.

Review of attachment 802090 [details] [diff] [review]:
-----------------------------------------------------------------

The new includes seem to make much more sense on average than the prior ones. r=me
Attachment #802090 - Flags: review?(terrence) → review+
https://hg.mozilla.org/mozilla-central/rev/6f22b81ed9b4
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.