914508 - Remove more stuff out of inlines.h/-inl.h files, and remove some unnecessary #include statements.

Status: RESOLVED FIXED

(Core :: JavaScript Engine, defect)

Description

[Nicholas Nethercote [inactive]]

More ice-cream and merry-go-rounds.

Comment 1

[Nicholas Nethercote [inactive]]

Attachment: Remove more stuff out of inlines.h/-inl.h files, and remove some unnecessary #include statements.

Sorry, I accidentally combined two distinct patches and was too lazy to
disentangle them.  What's going on here:

- I removed a bunch of unnecessary header inclusions, mostly inlines.h/-inl.h
  ones, as identified by IWYU.  Due to pre-existing bootlegging, some new
  #include statements had to be added.

- I moved some stuff out of gc/Barrier-inl.h, jsobjinlines.h, vm/Runtime-inl.h,
  and vm/RegExpStatics-inl.h;  the last of these was removed entirely.
  
  If you're wondering why RegExpStatics::markFlagsSet() ended up in
  RegExpStatics.cpp, note that in RegExpStatics.h it was declared as
  non-inline, but in RegExpStatics-inl.h it was declared inline.  I've seen
  this kind of mismatch on quite a few functions that I've moved out of -inl.h
  files recently.

Comment 2

[Terrence Cole [:terrence]]

Comment on attachment 802090 [details] [diff] [review]
Remove more stuff out of inlines.h/-inl.h files, and remove some unnecessary #include statements.

Review of attachment 802090 [details] [diff] [review]:
-----------------------------------------------------------------

The new includes seem to make much more sense on average than the prior ones. r=me

Comment 3

[Nicholas Nethercote [inactive]]

https://hg.mozilla.org/integration/mozilla-inbound/rev/45975a811207

Comment 4

[Wes Kocher (:KWierso) (Not reading bugmail; email directly if needed)]

Backed out because it seemed to break Android 2.2 NoIon Opt builds in https://hg.mozilla.org/integration/mozilla-inbound/rev/ecfd306e73fc

https://tbpl.mozilla.org/php/getParsedLog.php?id=27676914&tree=Mozilla-Inbound

Comment 5

[Nicholas Nethercote [inactive]]

Second attempt:
https://hg.mozilla.org/integration/mozilla-inbound/rev/6f22b81ed9b4

Comment 6

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/6f22b81ed9b4