914572 - [keyboard][my] Myanmar language support

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

Description

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: basic layout 1

Myanmar language is defined in the Unicode Standard. Need the followings to support it 
- add a font in system/fonts
- add a keyboard layout

Comment 1

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: basic layout 2

Comment 2

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: alternate layout 1

Comment 3

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: alternate layout 2

Comment 4

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: an input example

Comment 5

[Kai-Zhen Li [:seinlin][:kli]]

Hi Rudy, How do you think about it?

Comment 6

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

We definitely can add new layout to built-in keyboard app.

As of the font, I am not so sure about it.
Have you tested this on device, if we do not have font for Myanmar, then we should file a bug like bug 843592 to track this.

Thanks.

Comment 7

[Tin Aung Lin]

If you guys want to use Font there is a list of Open Type fonts for our Language.
Have a look. I willing to help for our language.

http://www.myanmarlanguage.org/article/download-unicode-fonts-and-keyboards

Comment 8

[Tin Aung Lin]

Here is also a bunch of font listing.

https://github.com/yelinaung/mmfonts

Comment 9

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Rudy Lu [:rudyl] from comment #6)
> We definitely can add new layout to built-in keyboard app.
> 
> As of the font, I am not so sure about it.
> Have you tested this on device, if we do not have font for Myanmar, then we
> should file a bug like bug 843592 to track this.
> 
> Thanks.

Yes, I tested on nexus 4 with pre-release v1.2, there is no font for Myanmar language in B2G. I will file a new bug for the font.

Comment 10

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: key_align_left.png

Hi Rudy,

After I move the keyboard layout to pre-release v1.2 and tested on nexus 4, some keys are aligned to left with unknown reason. The same layout is good in emulator with v1.0.

Do you have some suggestion to me?

Comment 11

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

(In reply to kli from comment #10)
> Created attachment 803457 [details]
> key_align_left.png
> 
> Hi Rudy,
> 
> After I move the keyboard layout to pre-release v1.2 and tested on nexus 4,
> some keys are aligned to left with unknown reason. The same layout is good
> in emulator with v1.0.
> 
> Do you have some suggestion to me?

I think you mean aligned to right?
I am not sure of this, might be a font rendering issue?

Can you show us what it looks like on Unagi or other HVGA devices or share your WIP (work-in-progress_ patches so that we can try?
Thanks.

Comment 12

[Kai-Zhen Li [:seinlin][:kli]]

Yes, I mean the word is aligned to the right.
I don't have a HVGA devices in hand, do I can't try on it now. I will try if I can get one for testing from someone.
You can see as in attachment "basic layout 1", the alignment of each key is in centre.

Comment 13

[Rudy Lu [:rudyl] (inactive after 2015/7/3)]

Maybe we can test putting those characters in a plain html file, and see how it looks like to if this is a general issue for rendering or simply a keyboard issue.

Comment 14

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: myanmar keyboard on helix

Hi Rudy, 

I try on helix(1.1hd), the key alignment looks good, but it is not good on nexus 4.

You can get the keyboard layout from https://github.com/Seinlin/gaia/tree/myanmar-kb

But you will also need the font from https://github.com/Seinlin/moztt/tree/myanmar-font

Comment 15

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: Bug-914572-pull-request.html

Hi Rudy, 

Now Myanmar font is landed on moztt. Finally the font "Padauk" is selected. With this font the key align issue does no longer exist.

Comment 16

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: 2013-09-24-06-47-19.png

Basic layout view of Myanmar keyboard with Padauk font.

Comment 17

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: mm_kb.png

Hi Tin Aung Linn, Chit Thiri Maung, 

This keyboard layout is followed the Myanmar3 Unicode keyboard layout[1] and it is adapted to mobile device version. 

Can you help me to review and give a feedback+ if you think it is ok OR give me some suggestion?

Thanks!


[1]http://www.myanmarlanguage.org/sites/default/files/u6/Myanmar3_Unicode_keyboard_Layout.jpg

Comment 18

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 811029 [details]
mm_kb.png

Each keyboard layout page is switched as following rules - 

shift: 1->2, 2->1
123: 1->3, 2->3, 4->3
ABC: 3->1, 4->1
#+=: 3->4

Comment 19

[Tin Aung Lin]

Ok I am reviewing on it with some of my friends ? Can we have a sample installation for this keyboard support. I have my keon phone on hand.

Thanks for the efforts that all of your guys did.

Comment 20

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to tinaunglinn from comment #19)
> Ok I am reviewing on it with some of my friends ? Can we have a sample
> installation for this keyboard support. I have my keon phone on hand.
> 
> Thanks for the efforts that all of your guys did.

Which version is running on your keon phone? User or Engineering version? 
May be I can provide you the keyboard and fonts together with the installation guide.

Comment 21

[Tin Aung Lin]

Attachment: 2013-09-29-17-43-36.png

I am using a Keon phone which run B2G 1.0.1.0 prerelease version.
Here is the screenshot.

Comment 22

[Kai-Zhen Li [:seinlin][:kli]]

Hi, Tin Aung Linn, 

If you want to test on Keon, you can get the App from https://github.com/Seinlin/mm-kb, and see INSTALL for details.

Please remember to backup the related files on your phone before you push to it.

Comment 23

[Tin Aung Lin]

It works really great ! We need more testing suite case for user experience. I will be back after I have test any possible use case.

Thanks to you
Tin Aung Lin

Comment 24

[Kai-Zhen Li [:seinlin][:kli]]

Comment on attachment 811029 [details]
mm_kb.png

Already got the feedback from Tin Aung Linn.

Comment 25

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Question: shouldn't the language named "Burmese" with language code "my"?

https://en.wikipedia.org/wiki/Burmese_language

Comment 26

[Kai-Zhen Li [:seinlin][:kli]]

I think both of "Burmese" and "Myanmar" are correct. And the Myanmar gov use "Myanmar" as official term.

From the wiki link: (Although the Constitution of Burma officially recognizes the English name of the language as the Myanmar language,[3] most English speakers continue to refer to the language as Burmese.)

I also notice that unicode.org use "Myanmar" - http://www.unicode.org/charts/


Tin Aung Linn, how do you think?

Comment 27

[Tin Aung Lin]

Myanmar +1

Comment 28

[Tim Guan-tin Chien [:timdream] (please needinfo)]

(In reply to Kai-Zhen Li from comment #26)
(In reply to tinaunglinn from comment #27)

Good to know, thanks!

Comment 29

[Kai-Zhen Li [:seinlin][:kli]]

Attachment: inari.png

Pull request is updated with the following changes
- use 'my' as language code instead of 'mm' which is country code.
- new coding style for Myanmar layout '\uXXXX'/*?*/, which can be readable in case the the editor doesn't support Myanmar font.

Comment 30

[Tim Guan-tin Chien [:timdream] (please needinfo)]

I am sorry that this bug does not land in time. However because of bug 884752 you would need to rebase your patch.

I've updated the documentation for you on that.
https://wiki.mozilla.org/Gaia/System/Keyboard/Layout

Comment 31

[Kai-Zhen Li [:seinlin][:kli]]

(In reply to Tim Guan-tin Chien [:timdream] (MoCo-TPE) (please ni?) from comment #30)
> I am sorry that this bug does not land in time. However because of bug
> 884752 you would need to rebase your patch.
> 
> I've updated the documentation for you on that.
> https://wiki.mozilla.org/Gaia/System/Keyboard/Layout

Hi Tim, rebase done and pull request is updated.

Comment 32

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Comment on attachment 809055 [details]
Bug-914572-pull-request.html

Stealing, will merge when Travis CI passes.

Comment 33

[Kai-Zhen Li [:seinlin][:kli]]

Myanmar keyboard is not built by default, it can be enabled by adding 'my' to "GAIA_KEYBOARD_LAYOUTS" in gaia's Makefile.

Comment 34

[Tim Guan-tin Chien [:timdream] (please needinfo)]

Well, we are not enabling the layout in the Travis CI build anyway...

master: https://github.com/mozilla-b2g/gaia/commit/8b5f217ab0bb6fb5b8682e04ffd2c245d9ef75ab