Closed Bug 914591 Opened 11 years ago Closed 11 years ago

Session init API call not being sent after expiration

Categories

(Firefox OS Graveyard :: Gaia::Everything.me, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:1.3+)

RESOLVED FIXED
blocking-b2g 1.3+

People

(Reporter: evyatar, Assigned: evyatar)

References

Details

(Keywords: regression)

Attachments

(1 file)

The server sends a TTL value when initializing a session.
Currently we re-init the session ONLY on e.me init - meaning when the homescreen loads.

Need to re-init the session whenever it expires. Also make sure it doesn't interfere with user action - so if a user requests something and their session has expired, wait until they get a response and only then call the session init request.
Attachment #811685 - Flags: review?(ran)
Testing the branch I see that a "no connection" message appears often.
Click "TV" you get the message for a second and then results appear.
Load more - Message appears at the bottom and then disappears, showing results.
Fixed and pushed.
Status: NEW → ASSIGNED
Attachment #811685 - Flags: review?(ran) → review?(amirn)
Just making a note - this patch also handles reporting cached icons on session init.

Added comments on Github.
Attachment #811685 - Flags: review?(amirn) → review+
blocking-b2g: --- → koi?
blocking-b2g: koi? → koi+
Keywords: regression
merged to master
9b118f3b66e4bfe77564af9cdcff886de7b8c004

https://github.com/mozilla-b2g/gaia/commit/9b118f3b66e4bfe77564af9cdcff886de7b8c004
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
I was not able to uplift this bug to v1.2.  If this bug has dependencies which are not marked in this bug, please comment on this bug.  If this bug depends on patches that aren't approved for v1.2, we need to re-evaluate the approval.  Otherwise, if this is just a merge conflict, you might be able to resolve it with:

  git checkout v1.2
  git cherry-pick -x -m1 9b118f3b66e4bfe77564af9cdcff886de7b8c004
  <RESOLVE MERGE CONFLICTS>
  git commit
Flags: needinfo?(evyatar)
John, looking in to the merge conflict, we would rather the patch not land in v1.2.

Current E.me code has undergone major refactoring and so landing this patch would mean redoing the needed changes and introducing unnecessary risk.

The patch is not critical as it influences mostly E.me servers.
Flags: needinfo?(evyatar)
Actually, amongst the bugs the this patch fixes is one that is crucial.
It is described and has a v1.2 specific patch in bug 932248 that should get nominated.
Blocks: 1.3-e.me
blocking-b2g: koi+ → 1.3?
blocking-b2g: 1.3? → 1.3+
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: