914602 - Make video size restriction customisable

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Camera, defect)

Description

[Beatriz Rodríguez [:brg]]

Video resolution is restricted now. 
Please make video size resolution customisable, this issue had been reported through aftersales channels.
Nominating to leo+

This issue is similar to bug 900399.

Comment 1

[Wayne Chang [:wchang]]

This dupes to bug 896425, which has a patch reviewed and landed on HD. If this gets granted leo+ we can simply land the patch from bug 896425 to v1-train and dupe this.

Comment 2

[Ivan Tsay (:ITsay)]

To fulfill the partner's request in bug 900399

Comment 3

[Joe Cheng [:jcheng] (please needinfo)]

hi David, IIRC, we limit the picture to 2MP to avoid gallery crashes. is this still true for v1.1 on a 256MB RAM device? thanks

Comment 4

[Yuren [:yurenju] (AFK ~ Oct. 12) (volunteer mode)]

Hi I had a pull request for v1-train which was already reviewed on bug 896425. feel free to merge it if needed.

https://github.com/mozilla-b2g/gaia/pull/12079

Comment 5

[Evelyn Hung]

(In reply to Joe Cheng [:jcheng] from comment #3)
> hi David, IIRC, we limit the picture to 2MP to avoid gallery crashes. is
> this still true for v1.1 on a 256MB RAM device? thanks
I see the code in Gallery has lifted picture size to 5MB.
https://github.com/mozilla-b2g/gaia/blob/v1-train/apps/gallery/js/MetadataParser.js#L19

Comment 6

[Evelyn Hung]

Just had a offline conversation with Joe, he think it's okay if we have lifted the restriction to 5MP.
I'm going to merge Yuren's PR on comment 4, since my WIP patch for bug 900399 depends on it.

Comment 7

[Evelyn Hung]

v1-train: https://github.com/mozilla-b2g/gaia/commit/52d4e499261a0a27a5341a51b751a68b0ddf64ce

Comment 8

[John Ford [:jhford] CET/CEST Berlin Time]

fixed on branch per comment 7