Let's remove MOZ_WIDGET_GTK2 and use MOZ_WIDGET_GTK everywhere. It helps to write the plugin code for gtk2/gtk3 toolkits.
Comment on attachment 805958 [details] [diff] [review] patch >+#if !(MOZ_WIDGET_GTK == 2) (MOZ_WIDGET_GTK != 2) or (MOZ_WIDGET_GTK > 2) please.
Attachment #805958 - Flags: review?(karlt) → review+
Comment on attachment 806488 [details] [diff] [review] patch for check in For single patch bugs, please just use the checkin-needed keyword :)
Attachment #806488 - Flags: checkin? → checkin+
This was backed out for crashtest-ipc and reftest-ipc failures, along with Linux mochitest-1 and reftest failures. Please rebase this patch and run it through Try again (linux32+64 opt+debug). If it's still green, it's probably a needs-clobber situation. In that case, please add a note to the CLOBBER file so that the build machines clobber first. Sorry for the hassle. https://tbpl.mozilla.org/php/getParsedLog.php?id=28095796&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=28099533&tree=Mozilla-Inbound https://tbpl.mozilla.org/php/getParsedLog.php?id=28099217&tree=Mozilla-Inbound
Martin, can you remove the DownloadPlatform.cpp changes here, please because bug 884708 has the appropriate solution there. That will have to land first. I'm guessing the failures are for new instances of MOZ_WIDGET_GTK2 somewhere, which is why we need to remove this variable. This kind of change shouldn't need a clobber.
Thanks. This patch does not touch configure.in nor DownloadPlatform.cpp so it sould be safe to apply it. We can do the configure.in change later when all parts are done.
Attachment #807654 - Flags: review+
Comment on attachment 807656 [details] [diff] [review] patch, v3 Try for this patch: https://tbpl.mozilla.org/?tree=Try&rev=9a2d7be2480f
Are you going to fix comm-central too?
(In reply to Philip Chee from comment #12) > Are you going to fix comm-central too? Ahh, good point. I'll add it to my todo-list.
Attachment #806488 - Attachment is obsolete: true
Looks like .js preprocessor doesn't like brackets. Fixed and pushed to try: https://tbpl.mozilla.org/?tree=Try&rev=2e6cc43acec5
Comment on attachment 808503 [details] [diff] [review] patch, v4 Please land this patch before Bug 917270.
Status: NEW → RESOLVED
Last Resolved: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla27
You need to log in before you can comment on or make changes to this bug.