914611 - Inconsistent references to plugin placeholder elements

Status: RESOLVED FIXED

(SeaMonkey :: General, defect)

Description

[[e-mail]]

Now that bug 910899 added anonids to the plugin placeholder elements that need it, the front-end code should switch to use them consistently.

Comment 1

[[e-mail]]

Attachment: Proposed patch

Comment 2

[Frank Wein [:mcsmurf]]

Neil: Looks like our CTP overlay is broken on trunk, so I'm having a hard time testing everything related to plugin placeholder elements.

Comment 3

[Frank Wein [:mcsmurf]]

Though..maybe this is only a CSS style mistake? Are your comments in Bug 790483 related to that? The plugin placeholder code displays fine in DOMI, it's just the styling being wrong?

Comment 4

[[e-mail]]

Yes, try the patch in bug 920927.

Comment 5

[Frank Wein [:mcsmurf]]

Comment on attachment 802287 [details] [diff] [review]
Proposed patch

That patch in the other bug did not fix it, but r+ for now since this patch seems to block other work/patches (and the patch looks good via code inspection). Need to re-investigate/file a new bug for the CTP problem.

Comment 6

[[e-mail]]

Ah of course, you need my as yet nonexistent patch to bug 920677 too.

Comment 7

[[e-mail]]

http://hg.mozilla.org/comm-central/rev/ed457090123f

Comment 8

[[e-mail]]

Comment on attachment 802287 [details] [diff] [review]
Proposed patch

[Approval Request Comment]
Regression caused by (bug #): 790483 via 920677
User impact if declined: No placeholder UI for CTP plugins
Testing completed (on m-c, etc.): Landed on c-c
Risk to taking this patch (and alternatives if risky): Low
String changes made by this patch: None

Comment 9

[[e-mail]]

Boy, I made a mess of that checkin...

Comment 10

[[e-mail]]

https://hg.mozilla.org/releases/comm-aurora/rev/8d8ad654fd85

Comment 11

[Frank Wein [:mcsmurf]]

Unsetting flag to make bug appear in the fixed bugs for SeaMonkey 2.23 list only (target milestone is enough for trunk).