914643 - Take out, or hide, the "remix" option in the make details bar for a goggles make

Status: RESOLVED FIXED

(Webmaker Graveyard :: X-Ray Goggles, defect)

Description

[info]

User Agent: Mozilla/5.0 (X11; Linux i686) AppleWebKit/537.1 (KHTML, like Gecko) Ubuntu/11.10 Chromium/21.0.1180.89 Chrome/21.0.1180.89 Safari/537.1

Steps to reproduce:

When I completed remixes and published them, I clicked the edit button on https://webmaker.org/me

This may be related to Goggles remixes that have additional problems detailed here https://bugzilla.mozilla.org/show_bug.cgi?id=914639


Actual results:

I got a 404 link

e.g. http://stephenfortune.makes.org/goggles/stephenfortunes-remix-of-buzzfeed-2/edit returns 404

Comment 1

[info]

Attachment: Details of browsers and systems used while debugging on my side

Details of browsers and systems used while debugging on my side

Comment 2

[Kat Braybrooke [:codekat]]

Cheers, thanks for filing these Stephen. Pomax and crew, for context, Stephen is one of our Webmaker Fellows, so he's helping us QA test the site while making awesome creations in the next month or so :)

Comment 3

[Pomax]

There should not actually be a remix button. The goggles aren't a remixing tool, so remix can't point to anything sensible (at least not until thimble is able to load arbitrary URLs). Morphing this bug to one for taking out or hiding the remix button on a goggles make.

Comment 4

[info]

Ok, but aside from the remix button I am completely unable to edit the data associated with that make, which is primary issue. And is that why the page points to a 404 when the edit button is pressed?

Comment 5

[Pomax]

yes, once you publish a goggles make, that's it. Goggles.webmaker has no tools that let you edit a make after you published it, unlike thimble or popcorn. So the question is what you wanted to edit:

1) "make" information: interesting idea, I wonder if we can easily surface make details in an editable form.

2) The actual content of the page you published: not possible through goggles, as it only knows how to publish a DOM snapshot, it has no edit mode of any sort. 

In order to achieve (2), we'd need to start looking at having thimble load up goggle projects (somehow), or arbitrary URLs for remixing.

Comment 6

[info]

Hi Mike,

I think the below would be a really useful addition

1) "make" information: interesting idea, I wonder if we can easily surface make details in an editable form.

For one it would allow Goggles makes to be filtered on the main homepage 
For another it would enable better make management on the users side. At present the Goggles makes accumulate in a remix-of-remix-of-remix-of naming convention and it's extremely hard to keep track of your personal make library

Comment 7

[Pomax]

ideally this means we add the same UI we use for popcorn and thimble when you hit publish in goggles, so you can pick the "vanity title" as well as add tags and thumbnails. That might actually already be enough to prevent the remix of remix of remix of remix of a headache.

Comment 8

[Pomax]

Attachment: https://github.com/mozilla/webmaker.org/pull/431

Comment 9

[Pomax]

brett: I've filed a patch that removes the "remix" option from goggles make tiles in the webmaker.org/me route (Which is what all our "my makes" links point to), I suspect that's enough to resolve this, but just in case you have more thoughts: thoughts?

Comment 10

[Brett Gaylor [:brett]]

works for me!

Comment 11

[inactivate account for kate]

Comment on attachment 817472 [details] [review]
https://github.com/mozilla/webmaker.org/pull/431

A nit/suggestion in the PR, do that/comment and this is R+

Comment 12

[[github robot]]

Commit pushed to master at https://github.com/mozilla/webmaker.org

https://github.com/mozilla/webmaker.org/commit/db1426dded93f44fa143a30cba5c2306906dbbb9
Merge pull request #431 from Pomax/bug914643

excepting the 'edit' link for application/x-x-ray-goggles

Comment 13

[Pomax]

suggestion worked in and landed.