Closed
Bug 914663
Opened 11 years ago
Closed 11 years ago
[keyboard] keyboard app and keyboard manager should use Browser API to send/get IME height
Categories
(Firefox OS Graveyard :: Gaia::Keyboard, defect)
Tracking
(blocking-b2g:koi+)
RESOLVED
FIXED
blocking-b2g | koi+ |
People
(Reporter: GaryChen, Assigned: GaryChen)
References
Details
(Whiteboard: [ft:system-platform])
Attachments
(1 file)
According to we have new Browser API to provide app to expose their own iframe's width and height information, so we should remove hack parts in keyboard app and keyboard manager.
Assignee | ||
Updated•11 years ago
|
Assignee: nobody → gchen
Assignee | ||
Comment 1•11 years ago
|
||
Attachment #802381 -
Flags: review?(rlu)
Assignee | ||
Comment 2•11 years ago
|
||
Hi Rudy, Please help this patch, I will close https://github.com/mozilla-b2g/gaia/pull/12073 after I get r+ from you.
Updated•11 years ago
|
blocking-b2g: koi? → koi+
Whiteboard: [ft:system-platform]
Comment 3•11 years ago
|
||
Comment on attachment 802381 [details] pull request: https://github.com/mozilla-b2g/gaia/pull/12084 r+ with some nits addressed, please refer to the pull request for details. Thanks.
Attachment #802381 -
Flags: review?(rlu) → review+
Assignee | ||
Comment 4•11 years ago
|
||
Hi Rudy, thanks for your review, I've addressed your comment please review it again. https://github.com/mozilla-b2g/gaia/pull/12084/files
Flags: needinfo?(rlu)
Comment 5•11 years ago
|
||
r+ already, so please help merge it. I also tested this with device/browser nightly/b2g desktop, should be working for all of them. Thanks.
Flags: needinfo?(rlu)
Assignee | ||
Comment 6•11 years ago
|
||
thanks, merged https://github.com/mozilla-b2g/gaia/commit/dafc64f14717f6f65f5d9b7a5f4faafaa7513b30 https://github.com/mozilla-b2g/gaia/commit/8d5b91c4bf197247cf46e4d4b5fd425e2edc1298
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•