Closed Bug 914663 Opened 11 years ago Closed 11 years ago

[keyboard] keyboard app and keyboard manager should use Browser API to send/get IME height

Categories

(Firefox OS Graveyard :: Gaia::Keyboard, defect)

ARM
Gonk (Firefox OS)
defect
Not set
normal

Tracking

(blocking-b2g:koi+)

RESOLVED FIXED
blocking-b2g koi+

People

(Reporter: GaryChen, Assigned: GaryChen)

References

Details

(Whiteboard: [ft:system-platform])

Attachments

(1 file)

According to we have new Browser API to provide app to expose their own iframe's width and height information, so we should remove hack parts in keyboard app and keyboard manager.
blocking-b2g: --- → koi?
See Also: → 891763
Assignee: nobody → gchen
Hi Rudy,
   Please help this patch,
   I will close https://github.com/mozilla-b2g/gaia/pull/12073 after I get r+ from you.
blocking-b2g: koi? → koi+
Whiteboard: [ft:system-platform]
Comment on attachment 802381 [details]
pull request: https://github.com/mozilla-b2g/gaia/pull/12084

r+ with some nits addressed, please refer to the pull request for details.
Thanks.
Attachment #802381 - Flags: review?(rlu) → review+
Hi Rudy,
   thanks for your review, I've addressed your comment please review it again.
   https://github.com/mozilla-b2g/gaia/pull/12084/files
Flags: needinfo?(rlu)
r+ already, so please help merge it.
I also tested this with device/browser nightly/b2g desktop, should be working for all of them.

Thanks.
Flags: needinfo?(rlu)
You need to log in before you can comment on or make changes to this bug.