Add WebIDL headers to install manifest

RESOLVED FIXED in mozilla26

Status

RESOLVED FIXED
5 years ago
10 months ago

People

(Reporter: gps, Assigned: gps)

Tracking

Trunk
mozilla26
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

(Assignee)

Description

5 years ago
WebIDL files are now tracked in moz.build (bug 912197). This means we can now track the .h files via install manifests. As part of this, we could also generate the .h files directly into dist/include if we so desired.
(Assignee)

Updated

5 years ago
Depends on: 914706
(Assignee)

Comment 1

5 years ago
Created attachment 802438 [details] [diff] [review]
Part 1: Add WebIDL headers to dist/include install manifest

This reduces the number of files purged from dist/include by hundreds.
Attachment #802438 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Assignee: nobody → gps
(Assignee)

Comment 2

5 years ago
Created attachment 802466 [details] [diff] [review]
Part 2: Generate WebIDL headers directly into dist/include

This patch doesn't actually work. Just throwing it up for posterity.

The reason it doesn't work is that the generated .cpp files expect the
.h files to be in the current directory because they reference
"FooBinding.h" instead of "mozilla/dom/FooBinding.h" because test-only
bindings aren't exported. We could probably have different code paths
for test-only bindings and generate non-test-only .h directly into
dist/include. But that's followup territory. And, it may never be high
enough on the priority list to warrant doing. So let's just leave this
bug as the first part.
(Assignee)

Comment 3

5 years ago
Created attachment 802470 [details] [diff] [review]
Add WebIDL headers to dist/include install manifest

Don't add test-only .h files to the manifest.
Attachment #802470 - Flags: review?(mh+mozilla)
(Assignee)

Updated

5 years ago
Attachment #802438 - Attachment is obsolete: true
Attachment #802438 - Flags: review?(mh+mozilla)
Attachment #802470 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/322e3797b68b
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26

Updated

10 months ago
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.