Closed Bug 914704 Opened 7 years ago Closed 7 years ago

Add WebIDL headers to install manifest

Categories

(Firefox Build System :: General, defect)

defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: gps, Assigned: gps)

References

Details

Attachments

(2 files, 1 obsolete file)

WebIDL files are now tracked in moz.build (bug 912197). This means we can now track the .h files via install manifests. As part of this, we could also generate the .h files directly into dist/include if we so desired.
Depends on: 914706
This reduces the number of files purged from dist/include by hundreds.
Attachment #802438 - Flags: review?(mh+mozilla)
Assignee: nobody → gps
This patch doesn't actually work. Just throwing it up for posterity.

The reason it doesn't work is that the generated .cpp files expect the
.h files to be in the current directory because they reference
"FooBinding.h" instead of "mozilla/dom/FooBinding.h" because test-only
bindings aren't exported. We could probably have different code paths
for test-only bindings and generate non-test-only .h directly into
dist/include. But that's followup territory. And, it may never be high
enough on the priority list to warrant doing. So let's just leave this
bug as the first part.
Don't add test-only .h files to the manifest.
Attachment #802470 - Flags: review?(mh+mozilla)
Attachment #802438 - Attachment is obsolete: true
Attachment #802438 - Flags: review?(mh+mozilla)
Attachment #802470 - Flags: review?(mh+mozilla) → review+
https://hg.mozilla.org/mozilla-central/rev/322e3797b68b
Status: NEW → RESOLVED
Closed: 7 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
Product: Core → Firefox Build System
You need to log in before you can comment on or make changes to this bug.