914705 - [B2G] [Settings] Date & Time: All months display 31 days in the date selector.

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Darren]

Description:
When manually changing the date all months are showing that they have 31 days in them.

Repro Steps:
1. Load Buri Build ID: 20130906040204
2. Open the Settings app
3. Navigate to the Date & Time menu.
4. Turn off "Set Automatically"
5. Tap on the date to go into date selector
6. Navigate through each of the months

Actual Results:
All the months display 31 days.

Expected Results:
Each of the months will display the correct number of days either on a non-leap or leap year.

Environmental Variables
Gecko: http://hg.mozilla.org/mozilla-central/rev/ab5f29823236
Gaia: 94e5f269874b02ac0ea796b64ab995fce9efa4b3
Platform Version: 26.0a1

Comment 1

[sarsenyev]

There is no regression window for 1.2
This UI appears on the 1.1 as well,
Even if it displays 31 day, a user cannot choose the 31st manually if that mouth has only 30 days
UI in the 1.01 displays dates accordingly to the calendar month, if the month has 30 days only.  it shows only 30 days

Comment 2

[Jason Smith [:jsmith]]

Okay - not a regression from 1.1 then, but a regression from 1.01.

Comment 3

[Arthur Chen [:arthurcc][inactive after 6/30]]

The issue was regressed by this commit: https://github.com/mozilla-b2g/gaia/commit/1b217322e4c23eb6c6679ad37d368d81cd61e1bf, in which the class name 'value-picker' was removed.

Comment 4

[Arthur Chen [:arthurcc][inactive after 6/30]]

Attachment: Link to https://github.com/mozilla-b2g/gaia/pull/12411

Alive, Pavel, could you help check the change? Thanks.

Comment 5

[Arthur Chen [:arthurcc][inactive after 6/30]]

master: 9b9b360c9b73e5163ff3b752b741b839e7607d60