If you think a bug might affect users in the 57 release, please set the correct tracking and status flags for Release Management.

Filter out app tags from publish details form in thimble

VERIFIED FIXED

Status

Webmaker
webmaker.org
VERIFIED FIXED
4 years ago
4 years ago

People

(Reporter: OpenMatt, Assigned: thecount)

Tracking

Details

(Whiteboard: [mentor][crossteambugs])

Attachments

(1 attachment)

* Right now if you remix a recommended teaching kit from https://webmaker.org/teach and hit "publish," it will pull the previous meta-tags into the new tagging UI -- as expected. This is how it's designed to work.

* This poses a problem, however: it pulls in the tag "webmaker:teach" as well. This is the tag that admins are using to control which teaching kits get recommended / appear on /teach

* Does this mean that any user can now add kits to that page? If so, we'll need to solve for that.
(Reporter)

Comment 1

4 years ago
* Just talked to Kate -- basically we just need to ensure the "webmaker:teach" app tag gets filtered out from the "publish" detail form.
(Reporter)

Updated

4 years ago
Summary: Ensure new tagging system does not impact admin-only curation tags like "webmaker:teach" → Filter out the "webmaker:teach" app tag from publish details form
this is still an issue, any updates?
Whiteboard: [mentor][crossteambugs]
(Reporter)

Updated

4 years ago
Flags: needinfo?(kate)
Flags: needinfo?(kate)
Summary: Filter out the "webmaker:teach" app tag from publish details form → Filter out app tags from publish details form in thimble
Right now the app tag -does- show up in the publish form, however, the MakeAPI will not accept any app tags (anything that starts with webmaker:, thimble: etc.) that are added by Thimble.

That said, it's a bit confusing for users to see the app tags in the first place -- we should only be displaying raw tags, not all tags.

It might be cool in the future to have some UI for admins only, but for now let's just fix this for end users
Assignee: nobody → scott
(Assignee)

Comment 4

4 years ago
Created attachment 812133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/239
Attachment #812133 - Flags: review?(pomax)
Comment on attachment 812133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/239

r+ with a nit (change == to ===)
Attachment #812133 - Flags: review?(pomax) → review+
(Assignee)

Comment 6

4 years ago
Comment on attachment 812133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/239

Fixed. That one was a typo that happend to work >< was not intended.
Attachment #812133 - Flags: review+ → review?(pomax)
Attachment #812133 - Flags: review?(pomax) → review+
(Assignee)

Comment 7

4 years ago
Staged: https://github.com/mozilla/thimble.webmaker.org/commit/5782e109662145887ee721be0010be3801bbca8a

Needs verification.
Status: NEW → RESOLVED
Last Resolved: 4 years ago
Flags: needinfo?(scott)
Resolution: --- → FIXED
Attachment mime type: text/plain → text/x-github-pull-request
(Assignee)

Updated

4 years ago
Status: RESOLVED → VERIFIED
Flags: needinfo?(scott)
You need to log in before you can comment on or make changes to this bug.