914786 - Filter out app tags from publish details form in thimble

Status: VERIFIED FIXED

(Webmaker Graveyard :: webmaker.org, defect)

Description

[Matt Thompson (@OpenMatt :OpenMatt)]

* Right now if you remix a recommended teaching kit from https://webmaker.org/teach and hit "publish," it will pull the previous meta-tags into the new tagging UI -- as expected. This is how it's designed to work.

* This poses a problem, however: it pulls in the tag "webmaker:teach" as well. This is the tag that admins are using to control which teaching kits get recommended / appear on /teach

* Does this mean that any user can now add kits to that page? If so, we'll need to solve for that.

Comment 1

[Matt Thompson (@OpenMatt :OpenMatt)]

* Just talked to Kate -- basically we just need to ensure the "webmaker:teach" app tag gets filtered out from the "publish" detail form.

Comment 2

[Laura Hilliger [:epilepticrabbit]]

this is still an issue, any updates?

Comment 3

[inactivate account for kate]

Right now the app tag -does- show up in the publish form, however, the MakeAPI will not accept any app tags (anything that starts with webmaker:, thimble: etc.) that are added by Thimble.

That said, it's a bit confusing for users to see the app tags in the first place -- we should only be displaying raw tags, not all tags.

It might be cool in the future to have some UI for admins only, but for now let's just fix this for end users

Comment 4

[Scott [:thecount] Downe]

Attachment: https://github.com/mozilla/thimble.webmaker.org/pull/239

Comment 5

[Pomax]

Comment on attachment 812133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/239

r+ with a nit (change == to ===)

Comment 6

[Scott [:thecount] Downe]

Comment on attachment 812133 [details] [review]
https://github.com/mozilla/thimble.webmaker.org/pull/239

Fixed. That one was a typo that happend to work >< was not intended.

Comment 7

[Scott [:thecount] Downe]

Staged: https://github.com/mozilla/thimble.webmaker.org/commit/5782e109662145887ee721be0010be3801bbca8a

Needs verification.