Closed Bug 914792 Opened 6 years ago Closed 6 years ago

Calls to JS shell builtin 'newGlobal' pass ignored 'new-compartment' option

Categories

(Core :: JavaScript Engine, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: jimb, Assigned: jimb)

Details

Attachments

(1 file)

Originally, the JS shell 'newGlobal' builtin function would return a global in a new compartment if passed the string 'new-compartment' as its argument. When SpiderMonkey changed to create a new compartment for every global, this became the only possible behavior for newGlobal, and it was changed to ignore string arguments. However, the string arguments to the calls weren't removed, and are still appearing via cargo-culting in new JS tests.

The attached patch removes all these unused arguments from the calls to newGlobal in JS code in js/src.
Attachment #802511 - Flags: review?(luke)
Attachment #802511 - Flags: review?(luke) → review+
https://hg.mozilla.org/integration/mozilla-inbound/rev/4299c9aa391b
Assignee: general → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/4299c9aa391b
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.