Calls to JS shell builtin 'newGlobal' pass ignored 'new-compartment' option

RESOLVED FIXED in mozilla26

Status

()

RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: jimb, Assigned: jimb)

Tracking

unspecified
mozilla26
Points:
---
Bug Flags:
in-testsuite -

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
Created attachment 802511 [details] [diff] [review]
Remove ignored 'new-compartment' argument to newGlobal JS shell builtin.

Originally, the JS shell 'newGlobal' builtin function would return a global in a new compartment if passed the string 'new-compartment' as its argument. When SpiderMonkey changed to create a new compartment for every global, this became the only possible behavior for newGlobal, and it was changed to ignore string arguments. However, the string arguments to the calls weren't removed, and are still appearing via cargo-culting in new JS tests.

The attached patch removes all these unused arguments from the calls to newGlobal in JS code in js/src.
Attachment #802511 - Flags: review?(luke)

Updated

5 years ago
Attachment #802511 - Flags: review?(luke) → review+
(Assignee)

Comment 1

5 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/4299c9aa391b
Assignee: general → jimb
Status: NEW → ASSIGNED
Flags: in-testsuite-
Target Milestone: --- → mozilla26
https://hg.mozilla.org/mozilla-central/rev/4299c9aa391b
Status: ASSIGNED → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.