Closed
Bug 914832
Opened 11 years ago
Closed 11 years ago
[Contacts] Confirm dialog needs an asynchronous interface
Categories
(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)
Tracking
(blocking-b2g:koi+, b2g-v1.2 affected)
People
(Reporter: kgrandon, Assigned: kgrandon)
References
Details
(Keywords: perf, Whiteboard: [c= p=2 s=2013.09.20 u=1.2])
Attachments
(1 file)
As a part of bug 907907 we need to create an asynchronous interface for ConfirmDialog. Trying to address concerns about patch size by splitting the original work up.
|
Assignee | |
Updated•11 years ago
|
Whiteboard: [c= p=3 s= u=] → [c= p=2 s= u=]
|
|
Assignee | |
Comment 1•11 years ago
|
||
|
|
Assignee | |
Updated•11 years ago
|
Attachment #802857 -
Flags: review?(francisco.jordano)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
Just left you a message on github.
This change is making the unit test fail. A part from that, the rest of the code and functionality are looking good to me.
Adding someone from dialer to sign on the change :)
Attachment #802857 -
Flags: review?(francisco.jordano)
Attachment #802857 -
Flags: review?(etienne)
Attachment #802857 -
Flags: review-
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
Missed a part during the pull request split. This should be resolved now, thanks!
Attachment #802857 -
Flags: review- → review?(francisco.jordano)
|
||
Comment 4•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
"Contacts.utility is not a function|
This breaks the error handling in telephony_helper.js.
Attachment #802857 -
Flags: review?(etienne) → review-
|
|
Assignee | |
Comment 5•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
@etienne - Thanks for the review. Had some unintended code in there. This has been fixed and tested, thanks.
I saw it work on dialer, but I'm now getting a different error which I think is unrelated: E/GeckoConsole( 824): [JavaScript Error: "NS_ERROR_NOT_AVAILABLE: Component is not available"
This happens when calling: telephony.dial
Attachment #802857 -
Flags: review- → review?
|
|
||
Comment 6•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
working well, r=me on the dialer part with the comments addressed
Attachment #802857 -
Flags: review? → review+
|
|
||
Comment 7•11 years ago
|
||
Comment on attachment 802857 [details]
Github Pull Request
Great work, thanks a lot Kevin!
On our way for a better dom loading yay!!!
Attachment #802857 -
Flags: review?(francisco.jordano) → review+
|
|
Assignee | |
Comment 8•11 years ago
|
||
Thanks guys! Landed in master: https://github.com/mozilla-b2g/gaia/commit/4b6f97fc2dec5089618bb4469e901d80c39f3f33
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
|
||
Updated•11 years ago
|
Whiteboard: [c= p=2 s= u=] → [c= p=2 s= 2013.09.20 u=]
|
|
||
Updated•11 years ago
|
Whiteboard: [c= p=2 s= 2013.09.20 u=] → [c= p=2 s=2013.09.20 u=]
|
||
Comment 10•11 years ago
|
||
koi+ as it blocks another koi+
blocking-b2g: koi? → koi+
status-b2g-v1.2:
--- → affected
|
|
||
Updated•11 years ago
|
Priority: -- → P1
Whiteboard: [c= p=2 s=2013.09.20 u=] → [c= p=2 s=2013.09.20 u=1.2]
You need to log in
before you can comment on or make changes to this bug.
Description
•