914886 - use aria-disabled="true" instead of class="disabled"

Status: RESOLVED FIXED

(Firefox OS Graveyard :: Gaia::Settings, defect)

Description

[Eitan Isaacson [:eeejay]]

It is just as functional, plus the bonus of telling the accessibility API that a UI is unavailable.

Comment 1

[Eitan Isaacson [:eeejay]]

Attachment: [Settings] Use aria-disabled instead of disabled class

https://github.com/mozilla-b2g/gaia/pull/12096

Comment 2

[Eitan Isaacson [:eeejay]]

Attachment: [Settings] Use aria-disabled instead of disabled class

Oops, rebased on current master.

Comment 3

[Fabien Cazenave [:kaze]]

FTR: class names have been preferred because they’re quicker to resolve in CSS selectors than aria-* attributes. However, we still should use aria attributes wherever they are needed for accessibility reasons, obviously.

Comment 4

[Eitan Isaacson [:eeejay]]

Thanks!

https://github.com/mozilla-b2g/gaia/commit/0c20c48408855e0a80fc4504ab40872915f479b2

Comment 5

[Anthony Ricaud (:rik)]

I had to back this out since it is breaking the linter.
----- FILE : /home/travis/build/mozilla-b2g/gaia/apps/settings/js/storage.js -----
Line 181, E:0010: Missing semicolon at end of line
Line 183, E:0010: Missing semicolon at end of line

https://github.com/mozilla-b2g/gaia/commit/9a4487c6734739cd97710c64bf9db01c31e36087

You can prevent this by running the linter before committing |make linter|. If you have the linter installed and in your $PATH, git commit will run it on the modified files. We also run the linter on your pull request and you click on travis details from the Github page.

Comment 6

[Eitan Isaacson [:eeejay]]

Oops! Fixed and relanded :)

https://github.com/mozilla-b2g/gaia/commit/0df2b5199af4ea14a16783d897a01cfea6a8016e