914902 - IPC message "NOTE: %s process received `Goodbye'..." is interleaved with other output

Status: RESOLVED FIXED

(Core :: IPC, defect)

Description

[Mark Hammond [:markh] [:mhammond]]

Attachment: Use printf_stderr instead of printf

ipc/glue/AsyncChannel.cpp uses printf for the message (ie, uses stdout), but almost everwhere else writes to stderr.  On Windows at least, this can cause the message to be interleaved with other output - eg, from a recent try run.


02:07:58     INFO -  NOTE: child process r[Parent 3108] WARNING: RemoveObserver() called for unregistered observer: file e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/hal/Hal.cpp, line 205
02:07:58     INFO -  eceive[Parent 3108] WARNING: RemoveObserver() called for unregistered observer: file e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/hal/Hal.cpp, line 205
02:07:58     INFO -  d `Goodby[Parent 3108] WARNING: RemoveObserver() called for unregistered observer: file e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/hal/Hal.cpp, line 205
02:07:58     INFO -  e', closin[Parent 3108] WARNING: RemoveObserver() called for unregistered observer: file e:/builds/moz2_slave/try-w32-d-00000000000000000000/build/hal/Hal.cpp, line 205
02:07:58     INFO -  g down

The following trivial patch uses printf_stderr instead of printf.  cjones: requesting your review as I see you've touched other logging-ish code in that file.

Comment 1

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

Comment on attachment 802674 [details] [diff] [review]
Use printf_stderr instead of printf

I'm the original author of that file ;).  Let's just nuke that printf.

r=me for the nuke.

Comment 2

[Mark Hammond [:markh] [:mhammond]]

(In reply to Chris Jones [:cjones] [:warhammer] from comment #1)
> Comment on attachment 802674 [details] [diff] [review]
> Use printf_stderr instead of printf
> 
> I'm the original author of that file ;).  Let's just nuke that printf.

Thanks - I obviously didn't go back that far in the history :)

https://hg.mozilla.org/integration/mozilla-inbound/rev/3a9f27b2a213

Comment 3

[Chris Jones [:cjones] inactive; ni?/f?/r? if you need me]

:).  I didn't intend that to sound snotty or anything; your comment just amused me slightly :).

Comment 4

[Ed Morley [:emorley]]

https://hg.mozilla.org/mozilla-central/rev/3a9f27b2a213