Closed Bug 914940 Opened 6 years ago Closed 6 years ago

Remove some enablePrivilige calls

Categories

(Testing :: Mochitest, defect)

x86
macOS
defect
Not set

Tracking

(Not tracked)

RESOLVED FIXED
mozilla26

People

(Reporter: martijn.martijn, Assigned: martijn.martijn)

References

Details

Attachments

(1 file, 3 obsolete files)

Attached patch enablepriv.diff (obsolete) — Splinter Review
This removes some enablePrivilege calls mainly from the content/ subdirectory.

I haven't tested all test files locally.
Attached patch enablepriv.diff (obsolete) — Splinter Review
Pushed this to try: https://tbpl.mozilla.org/?tree=Try&rev=a1ec43a38b76
Assignee: nobody → martijn.martijn
Attachment #802725 - Attachment is obsolete: true
Comment on attachment 802726 [details] [diff] [review]
enablepriv.diff

Review of attachment 802726 [details] [diff] [review]:
-----------------------------------------------------------------

Try server is green.
Attachment #802726 - Flags: review?(jgriffin)
Comment on attachment 802726 [details] [diff] [review]
enablepriv.diff

Review of attachment 802726 [details] [diff] [review]:
-----------------------------------------------------------------

Nice!

::: content/base/test/copypaste.js
@@ +29,5 @@
>                                     .QueryInterface(Ci.nsILoadContext);
>  }
>  
>  function testCopyPaste (isXHTML) {
> +  //netscape.security.PrivilegeManager.enablePrivilege("UniversalXPConnect");

shall we just delete this line altogether?
Attachment #802726 - Flags: review?(jgriffin) → review+
Attached patch 914940.diff (for check-in) (obsolete) — Splinter Review
Yeah, forgot to remove that line.
Attachment #802726 - Attachment is obsolete: true
Keywords: checkin-needed
Attachment #802861 - Attachment is obsolete: true
https://hg.mozilla.org/mozilla-central/rev/a1a846de1a8a
Status: NEW → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Whiteboard: [fixed-in-fx-team]
Target Milestone: --- → mozilla26
Duplicate of this bug: 841410
You need to log in before you can comment on or make changes to this bug.