Fix build warnings in Moz2D

RESOLVED FIXED in mozilla26

Status

()

Core
Graphics
RESOLVED FIXED
4 years ago
4 years ago

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Tracking

unspecified
mozilla26
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

Comment hidden (empty)
(Assignee)

Comment 1

4 years ago
Created attachment 802745 [details] [diff] [review]
Patch
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #802745 - Flags: review?
(Assignee)

Updated

4 years ago
Attachment #802745 - Flags: review? → review?(bas)
Comment on attachment 802745 [details] [diff] [review]
Patch

Review of attachment 802745 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/SourceSurfaceCG.cpp
@@ +166,5 @@
>  
>    mImage = CreateCGImage(data, data, aSize, aStride, aFormat);
>  
>    if (!mImage) {
> +    free(data);

This is not just a warning. This actually is a potential bug! Good to see this fixed.
Attachment #802745 - Flags: review?(bas) → review+
(Assignee)

Comment 3

4 years ago
https://hg.mozilla.org/integration/mozilla-inbound/rev/d46ddeb29627
https://hg.mozilla.org/mozilla-central/rev/d46ddeb29627
Status: ASSIGNED → RESOLVED
Last Resolved: 4 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.