Closed Bug 914955 Opened 6 years ago Closed 6 years ago

Fix build warnings in Moz2D

Categories

(Core :: Graphics, defect)

defect
Not set

Tracking

()

RESOLVED FIXED
mozilla26

People

(Reporter: dzbarsky, Assigned: dzbarsky)

Details

Attachments

(1 file)

No description provided.
Attached patch PatchSplinter Review
Assignee: nobody → dzbarsky
Status: NEW → ASSIGNED
Attachment #802745 - Flags: review?
Attachment #802745 - Flags: review? → review?(bas)
Comment on attachment 802745 [details] [diff] [review]
Patch

Review of attachment 802745 [details] [diff] [review]:
-----------------------------------------------------------------

::: gfx/2d/SourceSurfaceCG.cpp
@@ +166,5 @@
>  
>    mImage = CreateCGImage(data, data, aSize, aStride, aFormat);
>  
>    if (!mImage) {
> +    free(data);

This is not just a warning. This actually is a potential bug! Good to see this fixed.
Attachment #802745 - Flags: review?(bas) → review+
https://hg.mozilla.org/mozilla-central/rev/d46ddeb29627
Status: ASSIGNED → RESOLVED
Closed: 6 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in before you can comment on or make changes to this bug.