Closed
Bug 914955
Opened 12 years ago
Closed 12 years ago
Fix build warnings in Moz2D
Categories
(Core :: Graphics, defect)
Core
Graphics
Tracking
()
RESOLVED
FIXED
mozilla26
People
(Reporter: dzbarsky, Assigned: dzbarsky)
Details
Attachments
(1 file)
|
1.14 KB,
patch
|
bas.schouten
:
review+
|
Details | Diff | Splinter Review |
No description provided.
|
Assignee | |
Comment 1•12 years ago
|
||
|
|
Assignee | |
Updated•12 years ago
|
Attachment #802745 -
Flags: review? → review?(bas)
|
||
Comment 2•12 years ago
|
||
Comment on attachment 802745 [details] [diff] [review]
Patch
Review of attachment 802745 [details] [diff] [review]:
-----------------------------------------------------------------
::: gfx/2d/SourceSurfaceCG.cpp
@@ +166,5 @@
>
> mImage = CreateCGImage(data, data, aSize, aStride, aFormat);
>
> if (!mImage) {
> + free(data);
This is not just a warning. This actually is a potential bug! Good to see this fixed.
Attachment #802745 -
Flags: review?(bas) → review+
|
|
Assignee | |
Comment 3•12 years ago
|
||
|
||
Comment 4•12 years ago
|
||
Status: ASSIGNED → RESOLVED
Closed: 12 years ago
Resolution: --- → FIXED
Target Milestone: --- → mozilla26
You need to log in
before you can comment on or make changes to this bug.
Description
•