915014 - "Ci is not defined" during B2G desktop mochitests

Status: RESOLVED FIXED

(Testing :: Mochitest, defect)

Description

[Jonathan Griffin (:jgriffin)]

When running mochitests on B2G desktop builds, we get the following error:

System JS : ERROR chrome://specialpowers/content/SpecialPowersObserverAPI.js:102
                     ReferenceError: Ci is not defined

This has to do with B2G compartment sharing and not inheriting the definition of Ci from the parent context.

Comment 1

[Jonathan Griffin (:jgriffin)]

Attachment: Define CI

Comment 2

[Jonathan Griffin (:jgriffin)]

try: https://tbpl.mozilla.org/?tree=Try&rev=23a632524dd3

Comment 3

[Joel Maher ( :jmaher ) (UTC -8)]

Comment on attachment 802843 [details] [diff] [review]
Define CI

Review of attachment 802843 [details] [diff] [review]:
-----------------------------------------------------------------

::: testing/specialpowers/content/SpecialPowersObserverAPI.js
@@ +5,5 @@
>  Components.utils.import("resource://gre/modules/Services.jsm");
>  
> +if (typeof(Ci) == 'undefined') {
> +  const Ci = Components.interfaces;
> +}

I recall an issue in the past where detecting this for CC required a try/catch.  If you have tested this and it works for the case where it was undefined, then all is well.

Comment 4

[Jonathan Griffin (:jgriffin)]

Yep it works, thanks.

Comment 5

[Jonathan Griffin (:jgriffin)]

Last  try job was causing some "redefinition of Ci" errors on desktop; here's a new one that passes for me locally:  https://tbpl.mozilla.org/?tree=Try&rev=3b1351ba4e4f

Comment 6

[Jonathan Griffin (:jgriffin)]

https://hg.mozilla.org/integration/mozilla-inbound/rev/bc729c5726bb

Comment 7

[Ryan VanderMeulen [:RyanVM]]

https://hg.mozilla.org/mozilla-central/rev/bc729c5726bb