Closed Bug 915018 Opened 11 years ago Closed 11 years ago

[Contacts] Lazy load overlay

Categories

(Firefox OS Graveyard :: Gaia::Contacts, defect, P1)

Product:
Firefox OS Graveyard
Component:
Gaia::Contacts
Platform:
ARM
Gonk (Firefox OS)
Type:
defect

Tracking

(blocking-b2g:koi+, b2g-v1.2 fixed)

Status:
RESOLVED FIXED
Milestone:
1.2 C2(Oct11)
Project Flags:
blocking-b2g koi+
Tracking Flags:
Tracking Status
b2g-v1.2 --- fixed

People

(Reporter: kgrandon, Assigned: kgrandon)

References

Details

(Keywords: perf, Whiteboard: [c= p=2 s=2013.10.04 u=1.2])

Attachments

(1 file)

Github Pull Request
222 bytes, text/html
kgrandon
: review+
jmcf
: review+
Details 
As a part of bug 907907 we need to create an asynchronous interface for overlay.

Trying to address concerns about patch size by splitting the original work up.
Attached file Github Pull Request — 

    
  

        Attachment #802864 -
        Flags: review?(jmcf)

        Attachment #802864 -
        Flags: review?(francisco.jordano)

    
    

    
  
Comment on attachment 802864 [details]
Github Pull Request

provided the nits are fixed and unit tests are passing

        Attachment #802864 -
        Flags: review?(jmcf) → review+

    
    

    
  
Comment on attachment 802864 [details]
Github Pull Request

Have already received a review from Francisco on this code.

        Attachment #802864 -
        Flags: review?(francisco.jordano) → review+

    
    

    
  
Landed in master: https://github.com/mozilla-b2g/gaia/commit/21ba8721f0544979f43dc52dd6be73c53062ad06
Status: ASSIGNED → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED

    
  
Whiteboard: [c= p=2 s= u=] → [c= p=2 s=2013.10.04 u=]

    
    

    
  
Dependent bug of a koi+ perf bug, noming.
blocking-b2g: --- → koi?

    
    

    
  
koi+ as it blocks another koi+
blocking-b2g: koi? → koi+

    
  
Priority: -- → P1
Whiteboard: [c= p=2 s=2013.10.04 u=] → [c= p=2 s=2013.10.04 u=1.2]

    
    

    
  
Uplifted 21ba8721f0544979f43dc52dd6be73c53062ad06 to:
v1.2: 2a8911dd81797cb6f62f3af397b09f698b62d07c

          status-b2g-v1.2:
          --- → fixed

    
  
Blocks: 923873

    
  
Target Milestone: --- → 1.2 C2(Oct11)

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: