[SMS] use more explicit l10n arguments in dialog.js

RESOLVED FIXED

Status

--
enhancement
RESOLVED FIXED
5 years ago
5 years ago

People

(Reporter: kaze, Assigned: kaze)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment)

(Assignee)

Description

5 years ago
The current `Dialog' object in the SMS app uses string parameters that are either raw text or l10n entity references, depending on the value of a boolean `l10n' attribute. Worse, this `l10n' attribute is now either a `false' boolean or an object that is used to pass l10n arguments.

I suggest to use explicit `l10nId' and `l10nArgs' arguments instead, for better readability and to ensure consistency with the rest of the code.
(Assignee)

Comment 1

5 years ago
Created attachment 802891 [details]
link to pull request

https://github.com/mozilla-b2g/gaia/pull/12108
Assignee: nobody → kaze
Attachment #802891 - Flags: review?(felash)
Comment on attachment 802891 [details]
link to pull request

review done

please ask review again once it's finished :) thanks
Attachment #802891 - Flags: review?(felash)
(Assignee)

Comment 3

5 years ago
Comment on attachment 802891 [details]
link to pull request

Comments addressed. :-)
Attachment #802891 - Flags: review?(felash)
Comment on attachment 802891 [details]
link to pull request

r=me, cheers !
Attachment #802891 - Flags: review?(felash) → review+
(Assignee)

Comment 5

5 years ago
Merged on master: https://github.com/mozilla-b2g/gaia/commit/590eb0359e843528223785c80e83dd5919880579
Status: NEW → RESOLVED
Last Resolved: 5 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.