Closed
Bug 915058
Opened 11 years ago
Closed 11 years ago
[SMS] use more explicit l10n arguments in dialog.js
Categories
(Firefox OS Graveyard :: Gaia::SMS, enhancement)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: kaze, Assigned: kaze)
Details
Attachments
(1 file)
The current `Dialog' object in the SMS app uses string parameters that are either raw text or l10n entity references, depending on the value of a boolean `l10n' attribute. Worse, this `l10n' attribute is now either a `false' boolean or an object that is used to pass l10n arguments. I suggest to use explicit `l10nId' and `l10nArgs' arguments instead, for better readability and to ensure consistency with the rest of the code.
|
Assignee | |
Comment 1•11 years ago
|
||
https://github.com/mozilla-b2g/gaia/pull/12108
Assignee: nobody → kaze
Attachment #802891 -
Flags: review?(felash)
|
||
Comment 2•11 years ago
|
||
Comment on attachment 802891 [details]
link to pull request
review done
please ask review again once it's finished :) thanks
Attachment #802891 -
Flags: review?(felash)
|
|
Assignee | |
Comment 3•11 years ago
|
||
Comment on attachment 802891 [details]
link to pull request
Comments addressed. :-)
Attachment #802891 -
Flags: review?(felash)
|
|
||
Comment 4•11 years ago
|
||
Comment on attachment 802891 [details]
link to pull request
r=me, cheers !
Attachment #802891 -
Flags: review?(felash) → review+
|
|
Assignee | |
Comment 5•11 years ago
|
||
Merged on master: https://github.com/mozilla-b2g/gaia/commit/590eb0359e843528223785c80e83dd5919880579
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•