Closed
Bug 915082
Opened 8 years ago
Closed 8 years ago
[FM Radio] Favorite toggle not working correctly
Categories
(Firefox OS Graveyard :: Gaia::FMRadio, defect, P1)
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: epang, Assigned: pzhang)
Details
(Whiteboard: visual design, visual-tracking)
Attachments
(2 files)
Hi Pin, From this link it doesn't look like the favorite button is working correctly. http://pinzhang.github.io/gaia/apps/fm/ off state - looks correct pressed state - the icon shouldn't change size on state - the icon should be yellow. I've attached the icons in case they are needed. Please let me know if you have any questions. Thanks
Assignee | ||
Comment 1•8 years ago
|
||
Hi Eric, please refresh the page (ctrl+f5), and check if the presssed favorite icon is correct, thanks.
Reporter | ||
Comment 2•8 years ago
|
||
the pressed state looks good now, but i don't see the on state yet. Thanks!
Flags: needinfo?(pzhang)
Assignee | ||
Comment 3•8 years ago
|
||
(In reply to Eric Pang [:epang] from comment #2) > the pressed state looks good now, but i don't see the on state yet. Thanks! It's OK, the online page does't work properly, because the shared JS files only be deployed in buillding process, you can install the FirefoxOS Simulator[1] in Firefox to check if the state-on icon is OK. BTW, the original icons has shadow effect, and the newer ones hasn't, you can check the comparison[2]. [1] https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/ [2] https://github.com/PinZhang/gaia/commit/7a23463e7e9356f58d76cb52b210096bbb111980
Flags: needinfo?(pzhang)
Reporter | ||
Comment 4•8 years ago
|
||
(In reply to Pin Zhang [:pzhang] from comment #3) > (In reply to Eric Pang [:epang] from comment #2) > > the pressed state looks good now, but i don't see the on state yet. Thanks! > > It's OK, the online page does't work properly, because the shared JS files > only be deployed in buillding process, you can install the FirefoxOS > Simulator[1] in Firefox to check if the state-on icon is OK. > > BTW, the original icons has shadow effect, and the newer ones hasn't, you > can check the comparison[2]. > > [1] https://addons.mozilla.org/en-US/firefox/addon/firefox-os-simulator/ > [2] > https://github.com/PinZhang/gaia/commit/ > 7a23463e7e9356f58d76cb52b210096bbb111980 Looks good, thanks! I removed the shadow since the speaker icon did not have it. This way they are more consistent.
Assignee | ||
Comment 5•8 years ago
|
||
Attachment #803082 -
Flags: review?(timdream)
Updated•8 years ago
|
Attachment #803082 -
Flags: review?(timdream) → review+
Comment 6•8 years ago
|
||
https://github.com/mozilla-b2g/gaia/commit/90436287280ae130faa10a706f1a23372e824b9d
Status: NEW → RESOLVED
Closed: 8 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•