Closed Bug 915098 Opened 11 years ago Closed 11 years ago

round-robin texture units during composition

Categories

(Core :: Graphics: Layers, defect)

x86
macOS
defect
Not set
normal

Tracking

()

RESOLVED WONTFIX

People

(Reporter: gal, Assigned: gal)

Details

Attachments

(1 file)

We currently only use texture unit 0. Our chipset friends are reporting that their driver doesn't do texture unit renaming internally, so we only utilize a fraction of the available fill rate.
Attached patch patchSplinter Review
Tested on mac only. This round-robins the texture units and should spread out the use of texture units better during composition. I will ask the silicon partner to test this.
Assignee: nobody → gal
Can you please test this patch and see whether this improves contention over texture units?
(In reply to Andreas Gal :gal from comment #2)
> Can you please test this patch and see whether this improves contention over
> texture units?

This was aimed at CodeAurora?
Flags: needinfo?(mvikram)
Yes. The vendor will test this. We are all a little doubtful we could possibly need this.
On a build that includes the patch: Comment 87  Ed Morley [:edmorley UTC+1] 2013-09-13 07:04:29 PDT, there is no tangible performance gain (which is evident while profiling it with and without this patch).
Flags: needinfo?(mvikram)
Looks like a WONTFIX to me then.
Status: NEW → RESOLVED
Closed: 11 years ago
Resolution: --- → WONTFIX
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: